Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landscape support of StatePlayerRecyclerViewAssembler #1347

Closed
rt4914 opened this issue Jun 17, 2020 · 2 comments
Closed

Landscape support of StatePlayerRecyclerViewAssembler #1347

rt4914 opened this issue Jun 17, 2020 · 2 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 17, 2020

Currently the interactions and button in StatePlayerRecyclerViewAssembler do not have full support for landscape mode. If learner types any answer in any input interaction, after configuration change that answer is lost. Also the enable/disable state of Submit button is not preserved.
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Type: Improvement labels Jun 17, 2020
@rt4914 rt4914 mentioned this issue Jun 18, 2020
Merged
8 tasks
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning
Copy link
Member

Related issue: #1468.

@rt4914: is this only describing the configuration change issues or additional landscape support? I'm wondering if we should split this up since only the particularly bad parts should black alpha (e.g. submit button state being wrong), but others can wait until later (e.g. pending answer being lost on rotation).

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 10, 2020

Filed smaller issues
#1591
#1592
#1593
#1594
#1595

Therefore closing this issue.

@rt4914 rt4914 closed this as completed Aug 10, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
2 participants
@rt4914 @BenHenning