From 6c08d882d3866436d1bf5ce9e07fd02db9657ba6 Mon Sep 17 00:00:00 2001 From: Rajat Talesra Date: Thu, 12 May 2022 23:49:22 +0530 Subject: [PATCH] Fix #3453 & #3454: Optimise UI pin related screens - pin_password_activity, admin_auth_activity, admin_pin_activity (#4355) * Fixed UI for mobile view * Optimised pin-password-activity.xml * admin_pin_activity.xml + nits * admin_auth_activity optimised * Nit fixes * Nit fixes --- .../profile/PinPasswordActivityPresenter.kt | 2 +- .../res/layout-land/admin_auth_activity.xml | 138 ---------- .../res/layout-land/admin_pin_activity.xml | 126 --------- .../admin_auth_activity.xml | 136 ---------- .../admin_pin_activity.xml | 127 --------- .../admin_auth_activity.xml | 125 --------- .../admin_pin_activity.xml | 134 --------- .../main/res/layout/admin_auth_activity.xml | 56 ++-- .../main/res/layout/admin_pin_activity.xml | 203 +++++++------- .../main/res/layout/pin_password_activity.xml | 255 +++++++++--------- app/src/main/res/values-land/dimens.xml | 35 ++- .../main/res/values-sw600dp-land/dimens.xml | 35 ++- .../main/res/values-sw600dp-port/dimens.xml | 43 ++- app/src/main/res/values/dimens.xml | 38 ++- 14 files changed, 384 insertions(+), 1069 deletions(-) delete mode 100644 app/src/main/res/layout-land/admin_auth_activity.xml delete mode 100644 app/src/main/res/layout-land/admin_pin_activity.xml delete mode 100644 app/src/main/res/layout-sw600dp-land/admin_auth_activity.xml delete mode 100644 app/src/main/res/layout-sw600dp-land/admin_pin_activity.xml delete mode 100644 app/src/main/res/layout-sw600dp-port/admin_auth_activity.xml delete mode 100644 app/src/main/res/layout-sw600dp-port/admin_pin_activity.xml diff --git a/app/src/main/java/org/oppia/android/app/profile/PinPasswordActivityPresenter.kt b/app/src/main/java/org/oppia/android/app/profile/PinPasswordActivityPresenter.kt index 1894391df81..1a7ba8e23dc 100644 --- a/app/src/main/java/org/oppia/android/app/profile/PinPasswordActivityPresenter.kt +++ b/app/src/main/java/org/oppia/android/app/profile/PinPasswordActivityPresenter.kt @@ -52,7 +52,7 @@ class PinPasswordActivityPresenter @Inject constructor( viewModel = pinViewModel } - binding.pinPassordToolbar.setNavigationOnClickListener { + binding.pinPasswordToolbar.setNavigationOnClickListener { (activity as PinPasswordActivity).finish() } diff --git a/app/src/main/res/layout-land/admin_auth_activity.xml b/app/src/main/res/layout-land/admin_auth_activity.xml deleted file mode 100644 index d8033a9423a..00000000000 --- a/app/src/main/res/layout-land/admin_auth_activity.xml +++ /dev/null @@ -1,138 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -