From 42ee1bdf74de28f79d9424c3ee90b3713198f332 Mon Sep 17 00:00:00 2001 From: masclot <103062089+masclot@users.noreply.github.com> Date: Thu, 28 Sep 2023 02:51:48 +0200 Subject: [PATCH] Fixes #4539: Replace CaseSensitiveEquals by Equals in dev assets (#5154) ## Explanation Fixes #4539: Replace the rule type CaseSensitiveEquals by Equals in dev assets. This only affects the topics used in dev environment. The rule type CaseSensitiveEquals is no longer supported. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing **Videos** |current|new| |-|-| |[fix_for_CaseSensitiveEquals_current.webm](https://github.com/oppia/oppia-android/assets/103062089/0ad9f1e9-a991-4908-8576-1aba964fadcb)|[fix_for_CaseSensitiveEquals_new.webm](https://github.com/oppia/oppia-android/assets/103062089/298270d9-6af2-4cb8-a9f0-6445e5abfdd6)| **Screenshots** |current|new| |-|-| |![Screenshot fix_for_CaseSensitiveEquals_current](https://github.com/oppia/oppia-android/assets/103062089/b135fce1-270e-46d9-b819-82833011988d)|![Screenshot fix_for_CaseSensitiveEquals_new](https://github.com/oppia/oppia-android/assets/103062089/443f966f-717b-4fab-b17a-11d52e817737)| --------- Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com> --- domain/src/main/assets/2mzzFVDLuAj8.json | 6 +++--- domain/src/main/assets/2mzzFVDLuAj8.textproto | 6 +++--- domain/src/main/assets/5NWuolNcwH6e.json | 4 ++-- domain/src/main/assets/5NWuolNcwH6e.textproto | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/domain/src/main/assets/2mzzFVDLuAj8.json b/domain/src/main/assets/2mzzFVDLuAj8.json index 9a7eed87bb2..4e5fa088efd 100644 --- a/domain/src/main/assets/2mzzFVDLuAj8.json +++ b/domain/src/main/assets/2mzzFVDLuAj8.json @@ -2463,7 +2463,7 @@ } } }, { - "rule_type": "CaseSensitiveEquals", + "rule_type": "Equals", "inputs": { "x": { "contentId": "14186351-eee4-40fa-8f20-960306cfe465", @@ -2818,7 +2818,7 @@ } } }, { - "rule_type": "CaseSensitiveEquals", + "rule_type": "Equals", "inputs": { "x": { "contentId": "c78bf24e-b510-4bac-a107-28a03dfa1c22", @@ -2826,7 +2826,7 @@ } } }, { - "rule_type": "CaseSensitiveEquals", + "rule_type": "Equals", "inputs": { "x": { "contentId": "338cb82a-5e6f-460a-8fa0-5a2510c1a31e", diff --git a/domain/src/main/assets/2mzzFVDLuAj8.textproto b/domain/src/main/assets/2mzzFVDLuAj8.textproto index dcd355095d0..f8cdd2299d4 100644 --- a/domain/src/main/assets/2mzzFVDLuAj8.textproto +++ b/domain/src/main/assets/2mzzFVDLuAj8.textproto @@ -3011,7 +3011,7 @@ states { } } } - rule_type: "CaseSensitiveEquals" + rule_type: "Equals" } } answer_groups { @@ -3472,7 +3472,7 @@ states { } } } - rule_type: "CaseSensitiveEquals" + rule_type: "Equals" } rule_specs { input { @@ -3484,7 +3484,7 @@ states { } } } - rule_type: "CaseSensitiveEquals" + rule_type: "Equals" } } answer_groups { diff --git a/domain/src/main/assets/5NWuolNcwH6e.json b/domain/src/main/assets/5NWuolNcwH6e.json index d334766c022..dcf1da3fe0f 100644 --- a/domain/src/main/assets/5NWuolNcwH6e.json +++ b/domain/src/main/assets/5NWuolNcwH6e.json @@ -861,7 +861,7 @@ } } }, { - "rule_type": "CaseSensitiveEquals", + "rule_type": "Equals", "inputs": { "x": { "contentId": "947c6855-b9e6-459d-a8f6-2b239e51d37f", @@ -2176,7 +2176,7 @@ } } }, { - "rule_type": "CaseSensitiveEquals", + "rule_type": "Equals", "inputs": { "x": { "contentId": "5d0d1769-2754-4f6a-9690-ba3675ce953d", diff --git a/domain/src/main/assets/5NWuolNcwH6e.textproto b/domain/src/main/assets/5NWuolNcwH6e.textproto index cac4f82089f..3b8c323fd19 100644 --- a/domain/src/main/assets/5NWuolNcwH6e.textproto +++ b/domain/src/main/assets/5NWuolNcwH6e.textproto @@ -1121,7 +1121,7 @@ states { } } } - rule_type: "CaseSensitiveEquals" + rule_type: "Equals" } } default_outcome { @@ -2807,7 +2807,7 @@ states { } } } - rule_type: "CaseSensitiveEquals" + rule_type: "Equals" } rule_specs { input {