Skip to content

Commit 3f407f2

Browse files
Removed Default region retention
1 parent 5220eb5 commit 3f407f2

File tree

4 files changed

+5
-43
lines changed

4 files changed

+5
-43
lines changed

app/src/main/java/org/oppia/android/app/player/state/ImageRegionSelectionInteractionView.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ class ImageRegionSelectionInteractionView @JvmOverloads constructor(
132132
userAnswerState
133133
)
134134
areasImage.addRegionViews()
135-
areasImage.maybeSelectDefaultRegion()
136135
performAttachment(areasImage)
137136
}
138137
}

app/src/main/java/org/oppia/android/app/player/state/itemviewmodel/ImageRegionSelectionInteractionViewModel.kt

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ import androidx.databinding.ObservableField
66
import org.oppia.android.R
77
import org.oppia.android.app.model.AnswerErrorCategory
88
import org.oppia.android.app.model.ClickOnImage
9-
import org.oppia.android.app.model.ImageInteractionState
109
import org.oppia.android.app.model.ImageWithRegions
1110
import org.oppia.android.app.model.Interaction
1211
import org.oppia.android.app.model.InteractionObject
13-
import org.oppia.android.app.model.Point2d
1412
import org.oppia.android.app.model.UserAnswer
1513
import org.oppia.android.app.model.UserAnswerState
1614
import org.oppia.android.app.model.WrittenTranslationContext
@@ -41,7 +39,6 @@ class ImageRegionSelectionInteractionViewModel private constructor(
4139
var errorMessage = ObservableField<String>("")
4240
private var isDefaultRegionClicked = false
4341
var answerText: CharSequence = ""
44-
private var dafaultRegionCoordinates: Point2d? = null
4542
val selectableRegions: List<ImageWithRegions.LabeledRegion> by lazy {
4643
val schemaObject = interaction.customizationArgsMap["imageAndRegions"]
4744
schemaObject?.customSchemaValue?.imageWithRegions?.labelRegionsList ?: listOf()
@@ -84,16 +81,11 @@ class ImageRegionSelectionInteractionViewModel private constructor(
8481
override fun onClickableAreaTouched(region: RegionClickedEvent) {
8582
when (region) {
8683
is DefaultRegionClickedEvent -> {
87-
dafaultRegionCoordinates = Point2d.newBuilder().apply {
88-
x = region.x
89-
y = region.y
90-
}.build()
9184
answerText = ""
9285
isAnswerAvailable.set(false)
9386
isDefaultRegionClicked = true
9487
}
9588
is NamedRegionClickedEvent -> {
96-
dafaultRegionCoordinates = null
9789
answerText = region.regionLabel
9890
isAnswerAvailable.set(true)
9991
}
@@ -128,14 +120,8 @@ class ImageRegionSelectionInteractionViewModel private constructor(
128120

129121
override fun getUserAnswerState(): UserAnswerState {
130122
return UserAnswerState.newBuilder().apply {
131-
if (answerText.isNotEmpty() || dafaultRegionCoordinates != null) {
132-
this.imageInteractionState = ImageInteractionState.newBuilder().apply {
133-
if (answerText.isNotEmpty()) {
134-
this.imageLabel = answerText.toString()
135-
} else {
136-
this.defaultRegionCoordinates = dafaultRegionCoordinates
137-
}
138-
}.build()
123+
if (answerText.isNotEmpty()) {
124+
this.imageLabel = answerText.toString()
139125
}
140126
this.answerErrorCategory = answerErrorCetegory
141127
}.build()

app/src/main/java/org/oppia/android/app/utility/ClickableAreasImage.kt

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import androidx.core.view.forEachIndexed
1010
import androidx.core.view.isVisible
1111
import org.oppia.android.R
1212
import org.oppia.android.app.model.ImageWithRegions.LabeledRegion
13-
import org.oppia.android.app.model.Point2d
1413
import org.oppia.android.app.model.UserAnswerState
1514
import org.oppia.android.app.player.state.ImageRegionSelectionInteractionView
1615
import org.oppia.android.app.shim.ViewBindingShim
@@ -27,20 +26,13 @@ class ClickableAreasImage(
2726
userAnswerState: UserAnswerState
2827
) {
2928
private var imageLabel: String? = null
30-
private var defaultRegionCoordinates: Point2d? = null
31-
3229
private val defaultRegionView by lazy { bindingInterface.getDefaultRegion(parentView) }
3330

3431
init {
3532
imageView.initializeShowRegionTouchListener()
3633

37-
if (userAnswerState.hasImageInteractionState()) {
38-
if (userAnswerState.imageInteractionState.imageLabel.isNotBlank()) {
39-
imageLabel = userAnswerState.imageInteractionState.imageLabel
40-
} else {
41-
defaultRegionCoordinates =
42-
userAnswerState.imageInteractionState.defaultRegionCoordinates
43-
}
34+
if (userAnswerState.imageLabel.isNotBlank()) {
35+
imageLabel = userAnswerState.imageLabel
4436
}
4537
}
4638

@@ -90,13 +82,6 @@ class ClickableAreasImage(
9082
return imageView.height - imageView.paddingTop - imageView.paddingBottom
9183
}
9284

93-
/** Selects default region. */
94-
fun maybeSelectDefaultRegion() {
95-
defaultRegionCoordinates?.let {
96-
onPhotoTap(it.x, it.y)
97-
}
98-
}
99-
10085
/** Add selectable regions to [FrameLayout]. */
10186
fun addRegionViews() {
10287
// Remove all views other than the default region & selectable image.

model/src/main/proto/exploration.proto

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -441,18 +441,10 @@ message UserAnswerState {
441441
// A user's selected list of set of html content ids in drag and drop interaction.
442442
ListOfSetsOfTranslatableHtmlContentIds list_of_sets_of_translatable_html_content_ids = 4;
443443
// Image region selected by user.
444-
ImageInteractionState image_interaction_state=5;
444+
string image_label=5;
445445
}
446446
}
447447

448-
// Represents the state of image selection that the user has selected.
449-
message ImageInteractionState{
450-
// Selected image label.
451-
string image_label=1;
452-
// Selected default region coordinates.
453-
Point2d default_region_coordinates=2;
454-
}
455-
456448
// Represents categories of errors that can be inferred from a pending answer.
457449
enum AnswerErrorCategory {
458450
// The error is unknown or not specified.

0 commit comments

Comments
 (0)