From 392b1adcb342536f03743fbd0b18d99f1d58afdb Mon Sep 17 00:00:00 2001
From: Vraj Desai <43074241+vrajdesai78@users.noreply.github.com>
Date: Wed, 1 Sep 2021 22:22:24 +0530
Subject: [PATCH] Fixes #3465 Merge completed activity into single file (#3689)
* Completed_story merge into single file
* Completed_story_activity completed into single file
* Update dimens.xml
* Update completed_story_item.xml
* Update completed_story_list_fragment.xml
* Update dimens.xml
* Update dimens.xml
* Update dimens.xml
---
.../res/layout-land/completed_story_item.xml | 98 -------------------
.../completed_story_list_fragment.xml | 69 -------------
.../completed_story_item.xml | 96 ------------------
.../completed_story_list_fragment.xml | 69 -------------
.../completed_story_item.xml | 97 ------------------
.../completed_story_list_fragment.xml | 69 -------------
.../main/res/layout/completed_story_item.xml | 12 ++-
.../layout/completed_story_list_fragment.xml | 8 +-
app/src/main/res/values-land/dimens.xml | 12 +++
.../main/res/values-sw600dp-land/dimens.xml | 12 +++
.../main/res/values-sw600dp-port/dimens.xml | 13 +++
app/src/main/res/values/dimens.xml | 12 +++
12 files changed, 60 insertions(+), 507 deletions(-)
delete mode 100755 app/src/main/res/layout-land/completed_story_item.xml
delete mode 100644 app/src/main/res/layout-land/completed_story_list_fragment.xml
delete mode 100644 app/src/main/res/layout-sw600dp-land/completed_story_item.xml
delete mode 100644 app/src/main/res/layout-sw600dp-land/completed_story_list_fragment.xml
delete mode 100644 app/src/main/res/layout-sw600dp-port/completed_story_item.xml
delete mode 100644 app/src/main/res/layout-sw600dp-port/completed_story_list_fragment.xml
diff --git a/app/src/main/res/layout-land/completed_story_item.xml b/app/src/main/res/layout-land/completed_story_item.xml
deleted file mode 100755
index 8f42676f967..00000000000
--- a/app/src/main/res/layout-land/completed_story_item.xml
+++ /dev/null
@@ -1,98 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout-land/completed_story_list_fragment.xml b/app/src/main/res/layout-land/completed_story_list_fragment.xml
deleted file mode 100644
index e3f8827ee59..00000000000
--- a/app/src/main/res/layout-land/completed_story_list_fragment.xml
+++ /dev/null
@@ -1,69 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout-sw600dp-land/completed_story_item.xml b/app/src/main/res/layout-sw600dp-land/completed_story_item.xml
deleted file mode 100644
index 1b9229b289e..00000000000
--- a/app/src/main/res/layout-sw600dp-land/completed_story_item.xml
+++ /dev/null
@@ -1,96 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout-sw600dp-land/completed_story_list_fragment.xml b/app/src/main/res/layout-sw600dp-land/completed_story_list_fragment.xml
deleted file mode 100644
index 040270a6fd4..00000000000
--- a/app/src/main/res/layout-sw600dp-land/completed_story_list_fragment.xml
+++ /dev/null
@@ -1,69 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout-sw600dp-port/completed_story_item.xml b/app/src/main/res/layout-sw600dp-port/completed_story_item.xml
deleted file mode 100644
index 0b51a62cc3d..00000000000
--- a/app/src/main/res/layout-sw600dp-port/completed_story_item.xml
+++ /dev/null
@@ -1,97 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout-sw600dp-port/completed_story_list_fragment.xml b/app/src/main/res/layout-sw600dp-port/completed_story_list_fragment.xml
deleted file mode 100644
index 3cb5a1f29ba..00000000000
--- a/app/src/main/res/layout-sw600dp-port/completed_story_list_fragment.xml
+++ /dev/null
@@ -1,69 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/app/src/main/res/layout/completed_story_item.xml b/app/src/main/res/layout/completed_story_item.xml
index f5d0042edf6..c1e234fe6b7 100755
--- a/app/src/main/res/layout/completed_story_item.xml
+++ b/app/src/main/res/layout/completed_story_item.xml
@@ -15,10 +15,10 @@
android:id="@+id/topic_container"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_marginStart="8dp"
- android:layout_marginTop="12dp"
- android:layout_marginEnd="8dp"
- android:layout_marginBottom="12dp"
+ android:layout_marginStart="@dimen/completed_story_item_topic_container_margin_start"
+ android:layout_marginTop="@dimen/completed_story_item_topic_container_margin_top"
+ android:layout_marginEnd="@dimen/completed_story_item_topic_container_margin_end"
+ android:layout_marginBottom="@dimen/completed_story_item_topic_container_margin_bottom"
android:clickable="true"
android:focusable="true"
android:onClick="@{(v) -> viewModel.onCompletedStoryItemClicked()}"
@@ -35,13 +35,15 @@
android:layout_height="0dp"
android:contentDescription="@{viewModel.completedStory.storyName}"
android:importantForAccessibility="no"
+ android:scaleType="centerInside"
app:entityId="@{viewModel.completedStory.storyId}"
app:entityType="@{viewModel.entityType}"
app:layout_constraintDimensionRatio="4:3"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
- app:lessonThumbnail="@{viewModel.completedStory.lessonThumbnail}" />
+ app:lessonThumbnail="@{viewModel.completedStory.lessonThumbnail}"
+ app:topRoundedRectDrawableWithColor="@{viewModel.completedStory.lessonThumbnail.backgroundColorRgb}" />
diff --git a/app/src/main/res/values-land/dimens.xml b/app/src/main/res/values-land/dimens.xml
index a8aaad59435..4b51ff326bb 100644
--- a/app/src/main/res/values-land/dimens.xml
+++ b/app/src/main/res/values-land/dimens.xml
@@ -270,6 +270,18 @@
0dp
0dp
+
+ 16dp
+ 16dp
+ 12dp
+ 12dp
+
+
+ 56dp
+ 28dp
+ 56dp
+ 88dp
+
36dp
36dp
diff --git a/app/src/main/res/values-sw600dp-land/dimens.xml b/app/src/main/res/values-sw600dp-land/dimens.xml
index 7a2a6317a7d..f15655f2f9f 100644
--- a/app/src/main/res/values-sw600dp-land/dimens.xml
+++ b/app/src/main/res/values-sw600dp-land/dimens.xml
@@ -295,6 +295,18 @@
24dp
0dp
+
+ 32dp
+ 24dp
+ 32dp
+ 0dp
+
+
+ 64dp
+ 24dp
+ 64dp
+ 112dp
+
16dp
16dp
diff --git a/app/src/main/res/values-sw600dp-port/dimens.xml b/app/src/main/res/values-sw600dp-port/dimens.xml
index 5f2d189b885..d2f9881d062 100644
--- a/app/src/main/res/values-sw600dp-port/dimens.xml
+++ b/app/src/main/res/values-sw600dp-port/dimens.xml
@@ -303,6 +303,18 @@
24dp
28dp
+
+ 24dp
+ 24dp
+ 36dp
+ 0dp
+
+
+ 96dp
+ 12dp
+ 96dp
+ 112dp
+
360dp
52dp
@@ -312,4 +324,5 @@
48dp
100dp
+
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 5be488d6e0c..0be5019b680 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -458,6 +458,18 @@
36dp
108dp
+
+ 8dp
+ 8dp
+ 12dp
+ 12dp
+
+
+ 20dp
+ 20dp
+ 20dp
+ 144dp
+
16dp
16dp