From 3103b0c01ae1552f8f8f44361821937c19a45745 Mon Sep 17 00:00:00 2001 From: aayushimathur6 <92685651+aayushimathur6@users.noreply.github.com> Date: Thu, 5 Oct 2023 14:15:13 +0530 Subject: [PATCH] Fixes #2399: Reformatting required in dimension file for better structure (#5168) ## Explanation Fixes #2399 This PR has restructured the dimens.xml files. The file is too large so just rearranged the dimensions to form the groups on the base of their name, so that we find all the the dimensions related to a particular category at once with ease. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com> --- app/src/main/res/values/dimens.xml | 474 ++++++++++++++--------------- 1 file changed, 222 insertions(+), 252 deletions(-) diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index f14ef3f518e..11592246d65 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -18,348 +18,324 @@ 160dp 4dp 1dp + 18sp - 48dp + 0dp + 12dp + 12dp + 28dp 28dp 28dp + 16dp + + 28dp - 28dp - 28dp - 28dp + 16dp + 24dp + 20dp + + + 64dp + 36dp + 24dp + + + 60dp 28dp + 16dp + 16dp + 16dp + 16dp + 16dp + 16dp + 24dp + 24dp + 24dp + 24dp + 40dp + 8dp + 48dp + 298dp + 298dp + 4dp + 8dp + 4dp + 4dp + 12dp + 8dp + + 72dp + 72dp + 0dp + 84dp + 96dp + 96dp + 224dp + 28dp + 28dp + 16dp + 16dp + 16dp + 60dp + 24dp + 24dp 298dp 298dp - 298dp - 298dp + 48dp + 24dp + 24dp + 40dp + 32dp + 32dp 40dp + 24dp + 24dp + 32dp + 32dp 40dp + 32dp + 32dp + 24dp + 16dp + 16dp + 16dp + 16dp + 4dp + 4dp + 4dp + 80dp + 16dp + 16dp + 12dp + 8dp + 8dp + 8dp + 8dp + + + 72dp + 48dp + 32dp + 32dp + 28dp + 28dp + + 40dp + 24dp 40dp - 40dp - 40dp + 24dp 40dp + 24dp + 80dp + + + 40dp + 24dp + 24dp 40dp + 24dp + 24dp 40dp + 64dp + 64dp + 40dp + 24dp + 24dp 40dp 40dp - 40dp + 24dp + 24dp + 64dp + 64dp + 24dp + 24dp + 64dp + 64dp + 16dp + 16dp + 8dp + 8dp 28dp - 4dp - 4dp - 4dp - 0dp - 12dp - 12dp + + 20dp + 8dp + 20dp + + 60dp 60dp - 20dp - 20dp - 28dp - 28dp - 4dp - 8dp - 28dp - 8dp - 16dp - 12dp - 18sp - 20dp - 20dp - 20dp + 20dp + 24dp + 8dp + 8dp - 16dp - 16dp + 16dp + 24dp + 24dp 16dp 16dp 16dp 16dp 16dp + 24dp + 24dp 16dp 16dp 16dp 16dp + + 16dp + 24dp + 24dp 16dp 16dp 16dp 16dp 16dp + 24dp + 24dp 16dp 16dp 16dp 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - - 12dp - 12dp - 12dp - - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 60dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp 0dp + 0dp + 8dp 28dp 28dp 32dp 96dp 0dp 0dp - 0dp @dimen/match_parent + 0dp 28dp 28dp 32dp 96dp 0dp 0dp - 0dp 0dp + + -1px 28dp 28dp 40dp 0dp 0dp - - -1px - - 64dp - 64dp - 64dp - 64dp - 64dp - 64dp + 4dp - 4dp 2dp - 224dp - - 72dp - 72dp - 72dp - 80dp - 80dp - - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp - - 48dp - 48dp - 48dp + + 4dp - + 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 32dp 24dp 32dp 8dp - - 32dp 32dp 32dp 8dp - + 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 32dp 24dp 32dp - - 32dp 24dp 32dp - + 40dp 24dp 24dp 40dp 24dp - - 32dp 24dp 32dp 32dp 32dp - - - 32dp 24dp 32dp - - 16dp - 16dp - 16dp - 16dp - - 4dp - - 4dp - 4dp - 16dp 16dp - + 40dp 24dp 24dp - - 40dp 24dp 24dp - - 32dp 24dp 32dp - - 32dp 24dp 32dp - + 36dp 52dp - - 36dp 52dp - - 44dp 44dp - - 44dp 44dp @@ -369,44 +345,33 @@ the shadows are clearly visible around the buttons. --> - + 20dp 68dp 20dp - - 44dp 44dp - - 24dp 24dp 24dp 24dp - - 44dp 44dp - - 24dp 24dp 24dp 24dp - + 44dp - - 8dp - + 44dp 32dp 32dp - 12dp 32dp 8dp @@ -419,11 +384,18 @@ 124dp - + + 48dp + + + 12dp + + + 88dp + + 28dp 28dp - - 32dp 32dp @@ -438,18 +410,22 @@ 60dp 80dp - + 24dp 22dp 28dp 60dp 80dp - + 80dp 60dp + + 28dp 28dp + + 24dp 24dp 24dp @@ -461,13 +437,15 @@ 128dp - + 12dp - + 28dp 40dp 28dp + + 40dp 28dp 40dp @@ -478,17 +456,9 @@ 32dp 12dp - - 64dp - 36dp - 60dp - 96dp - 0dp - 84dp - 28dp - 96dp - - + + 16dp + 12dp 0dp 0dp 24dp @@ -498,7 +468,7 @@ 28dp 28dp - + 36dp 108dp @@ -519,7 +489,7 @@ 20dp 144dp - + 16dp 16dp 24dp @@ -532,18 +502,35 @@ 32dp 24dp + 36dp 148dp + 20dp + 20dp + 8dp + 28dp + 28dp + 4dp + + + + 0dp + 0dp + 0dp + 0dp - + 8dp 168dp + 28dp + 8dp + + 8dp 8dp 280sp - 280sp 16sp 8dp @@ -563,13 +550,6 @@ 32dp 32dp - - - 0dp - 0dp - 0dp - 0dp - 20dp 20dp @@ -589,6 +569,7 @@ 20dp 20dp 144dp + 8dp 12dp 8dp @@ -597,28 +578,27 @@ 8dp - 32dp - 12dp 28dp 28dp 20dp + 8dp + 32dp + 40dp + 40dp + 32dp + 12dp 12dp + 12dp 28dp 32dp 8dp + 0dp 8dp + 8dp 48dp 48dp - 0dp - 40dp - 40dp - 8dp - 32dp - 8dp - 12dp - 0dp 32dp 28dp 28dp @@ -629,6 +609,7 @@ 28dp 28dp 28dp + 0dp 32dp @@ -679,11 +660,10 @@ 32dp - 32dp 24dp - 24dp - 88dp 0dp + 32dp + 24dp 8dp @@ -698,7 +678,7 @@ 16dp 16dp - + 16dp 16dp 16dp @@ -707,34 +687,24 @@ 16dp 16dp 4dp - - - 16dp - 16dp - 16dp - 16dp - - 16dp 16dp 16dp 16dp - - 80dp - - 16dp 20dp 16dp 16dp 16dp - - 16dp 16dp 16dp 16dp + 16dp + 16dp + 16dp + 16dp 16dp @@ -770,10 +740,10 @@ 4dp + 28dp 12dp 20dp 12dp - 28dp 28dp 28dp 28dp