Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transferred from Web repo] Use consistent media queries for responsive design across different screen widths #153

Open
nikitaevg opened this issue Jun 18, 2024 · 2 comments

Comments

@nikitaevg
Copy link

Is your feature request related to a problem? Please describe.

There are currently [77 places](https://github.com/search?q=repo%3Aoppia%2Foppia%20%40media(max-width&type=code) which control markdown based on the screen width. They are probably not well synchronized and might work badly with each other.

Describe the solution (or solutions) you'd like

NOTE: that's not a confirmed problem, maybe there's no better solution for this.

  1. Unify the condition "is it a mobile page"
  2. Look through these places and get rid of unnecessary ones.

Describe alternatives you've considered and rejected

No response

Additional context

No response

@seanlip seanlip transferred this issue from oppia/oppia Jun 19, 2024
@seanlip seanlip changed the title [Feature Request]: Use consistent markdown for mobile/desktop versions [Transferred from Web repo] Use consistent media queries for mobile/desktop versions Jun 19, 2024
@seanlip
Copy link
Member

seanlip commented Jun 19, 2024

@nikitaevg By "markdown", you mean "media queries", right? Also just a note, your link is not working, did you mean this one?

For the design team -- this is a question from the Web team asking about how we should handle breakpoints. Currently, on Web, there are all sorts of breakpoints at various different screen sizes (1199 px, 1350 px, 1080 px, 641 px, etc.) for different pages and components. We would like to get the design team's advice on whether this should be standardized across all pages, and, if so, what the cutoffs between the different layout widths should be -- do we have a standard for this?

@seanlip seanlip changed the title [Transferred from Web repo] Use consistent media queries for mobile/desktop versions [Transferred from Web repo] Use consistent media queries for responsive design across different screen widths Jun 19, 2024
@nikitaevg
Copy link
Author

By "markdown", you mean "media queries", right?

Oh, I thought M in html is for "markdown":) Anyway, I just meant "page design", there are 77 places which control page design based on the width

For the broken link, hmm, let's try again, 77 places. Well it works in the preview. Thanks anyway

@nikitaevg nikitaevg removed their assignment Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Not Started
Development

No branches or pull requests

4 participants