Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples - Change the memcached image used in the samples so that we do not need to use RunAsUser #5934

Closed
camilamacedo86 opened this issue Jul 7, 2022 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Jul 7, 2022

What is the problem

I cannot run the samples on Openshift

Why

Because we are setting RunAsUser(1001) therefore, it will not work on OCP

Proposed Solution

Change the Memcached image: docker-library/memcached#79 ( To have the USER ID define )

OR

maintain a short Dockerfile that's auto-built with just FROM memcached \n USER 11211:11211 (if it has to be baked into the image itself)

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jul 7, 2022

c/c @everettraven @rashmigottipati

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jul 9, 2022

Done a PR to see if we can update the image: docker-library/memcached#79

It was tested locally and the Pod worked successfully without RunAsUser as expected:

pod/foozjpc-sample-654c75bf8f-fgbvv 1/1 Running 0 115s

@asmacdo asmacdo added this to the Backlog milestone Jul 11, 2022
@asmacdo
Copy link
Member

asmacdo commented Jul 11, 2022

blocked until docker-library/memcached#79 merges, but @camilamacedo86 will keep an eye on it.

@camilamacedo86 camilamacedo86 removed their assignment Aug 15, 2022
@camilamacedo86
Copy link
Contributor Author

I am unable to get the PR docker-library/memcached#79 merged.

Therefore, the other solution is to maintain a short Dockerfile that's auto-built with just FROM memcached \n USER 11211:11211 (if it has to be baked into the image itself)

Remove the assignment to allow others to work on this one.
Also, I improved the description to make it more clear.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jan 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2023

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants