Skip to content

Use Operator Controller types vs. Rukpak types #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmshort opened this issue May 29, 2024 · 1 comment
Closed

Use Operator Controller types vs. Rukpak types #896

tmshort opened this issue May 29, 2024 · 1 comment

Comments

@tmshort
Copy link
Contributor

tmshort commented May 29, 2024

In internal/controllers/common_controller.go:

rukpakv1alpha2 vs ocv1alpha1

Same for the other two unpack status conditions below.

		Type:               ocv1alpha1.TypeUnpacked,

Originally posted by @varshaprasad96 in #874 (comment)
@tmshort tmshort mentioned this issue May 29, 2024
Merged
4 tasks
@varshaprasad96 varshaprasad96 mentioned this issue May 31, 2024
Closed
11 tasks
@tmshort
Copy link
Contributor Author

tmshort commented Jun 13, 2024

This was basically fixed, with the exception of a function-based API, done in #905.

@tmshort tmshort closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmshort