Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document rationale of looking at "spanId" parameter #17

Open
codefromthecrypt opened this issue Sep 27, 2019 · 0 comments
Open

document rationale of looking at "spanId" parameter #17

codefromthecrypt opened this issue Sep 27, 2019 · 0 comments

Comments

@codefromthecrypt
Copy link
Contributor

Right now, we document "spanId" as what insures mechanisms such as TTL or gaps. This also solves a secondary problem, which is knowing if the sampling key was ever sampled before (ex same as b3 sampled=1). An alternative would be to add another field, or delimited property, to indicate the sampling status of the key. However, this would increase the parsing complexity and the overhead of the header.

I didn't mention aloud, but "spanId" serves the same purpose. The rationale summarizes as

things will break if you don't know the upstream span ID. Instead of adding a separate sampled parameter, which may lead to people not adding spanId and then breaking traces, we leverage "spanId" instead.

Note: we don't yet have a RATIONALE.md so this may imply creating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant