Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of Conflicting Keys during Automatic Conversion from Zipkin Tags to OTEL Semantic Attributes #10

Open
making opened this issue Aug 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@making
Copy link
Collaborator

making commented Aug 20, 2024

Feature

Handling of Conflicting Keys during Automatic Conversion from Zipkin Tags to OTEL Semantic Attributes

Rationale

Currently, the encoder automatically converts Zipkin tags to OTEL semantic attributes. However, this process does not account for situations where the resulting OTEL attribute key already exists within the original Zipkin tags. This can lead to conflicts or unintended overwriting of existing keys. Addressing this issue would provide greater control and prevent potential data inconsistencies, benefiting users who rely on precise attribute mapping during the conversion process.

Example Scenario

Consider a scenario where a Zipkin tag has a key that, when converted, results in an OTEL semantic attribute that matches an existing key in the original tags. This could cause the original data to be overwritten unintentionally. By either avoiding the conversion of existing keys or allowing users to configure whether or not these keys should be converted, the integrity of the data can be maintained.

@making making added the enhancement New feature or request label Aug 20, 2024
@making making mentioned this issue Aug 20, 2024
@codefromthecrypt
Copy link
Contributor

one thing to do is have a look at the otel collector codebase and if any defense is done there when they convert zipkin -> otel. maybe ping an author of that component for an opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants