Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep logs of letsencrypt and reverse-proxy container #772

Open
benoit74 opened this issue Oct 31, 2024 · 1 comment
Open

Keep logs of letsencrypt and reverse-proxy container #772

benoit74 opened this issue Oct 31, 2024 · 1 comment
Labels

Comments

@benoit74
Copy link

In https://github.com/openzim/wp1/blob/main/docker-compose.yml (prod configuration), logs of the reverse-proxy and letsencrypt containers are set to logging.driver: 'none', i.e. we immediately drop the logs.

During kiwix/operations#211, this prevented me to diagnose an issue (which wasn't really an issue), I had to modify the docker-compose and restart the container to check letsencrypt logs for instance.

While I admit that these logs are rarely useful, I think that dropping them immediately is a bit sad. I would be in favor of keeping at least few lines (e.g. the 10k which are in the config).

@rgaudin WDYT?

@rgaudin
Copy link
Member

rgaudin commented Nov 1, 2024

I think it would be wise ; as suggested, with a limit, so that we don't have to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants