feat: add hub leader config controller #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
=========================================
Coverage ? 45.30%
=========================================
Files ? 410
Lines ? 27152
Branches ? 0
=========================================
Hits ? 12301
Misses ? 13627
Partials ? 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 2 commits
February 7, 2025 08:56
# Conflicts: # pkg/yurtmanager/controller/base/controller.go
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 8, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Show resolved
Hide resolved
added 2 commits
February 10, 2025 09:37
tnsimon
force-pushed
the
add-hub-leader-config-controller
branch
from
cba4e4b to
f5b0b86
Compare
rambohe-ch
reviewed
Feb 10, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Show resolved
Hide resolved
rambohe-ch
reviewed
Feb 10, 2025
|
rambohe-ch
approved these changes
Feb 10, 2025
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds hubleader config controller to create configmap for the nodepool leader and pool scoped metadata
Which issue(s) this PR fixes:
Fixes #2260
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note
An internal CRD would be an improvement than a configmap to have a structured schema. Endpoints resource was not used due to character limitations using annotations to store poolscoped metadata. It was decided to use a config map instead.