-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The provided correct example for stripping leading whitespace is a Python heredoc that does not run #668
Comments
adamnovak
changed the title
The provided correct example for stripping leading whitespace is a Python script that does not run
The provided correct example for stripping leading whitespace is a Python heredoc that does not run
Jun 24, 2024
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The 1.1 spec gives this as a correct answer for stripping leading whitespace:
wdl/SPEC.md
Lines 3648 to 3655 in 9c0b9cf
But that Bash command will always fail. The Python script is indented by 2 spaces; Bash does not itself strip leading whitespace inside the heredoc. So Python will raise an
IndentationError
when parsing the script:The spec goes on to act as if this command can ever succeed, including by giving example output for the task containing it, which can never be obtained.
The text was updated successfully, but these errors were encountered: