Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing output variable in python_strip_task.wdl unit test #663

Open
stxue1 opened this issue Jun 18, 2024 · 0 comments
Open

Missing output variable in python_strip_task.wdl unit test #663

stxue1 opened this issue Jun 18, 2024 · 0 comments
Assignees
@jdidion

Comments

@stxue1
Copy link
Collaborator

stxue1 commented Jun 18, 2024

The python_strip_task.wdl unit test's output has the variable lines, but the expected json only has the namespace identifier:

wdl/SPEC.md

Line 3640 in 9c0b9cf

"python_strip": ["A", "B", "C"]

I think the proper name should be python_strip.lines
jdidion added a commit that referenced this issue Jun 26, 2024
@jdidion
update changelog, fix #663
efd4165
jdidion added a commit that referenced this issue Jun 26, 2024
@jdidion
update changelog, fix #663
4361edc
jdidion added a commit that referenced this issue Jun 26, 2024
@jdidion
update changelog, fix #663
4535d55
@jdidion jdidion mentioned this issue Jun 26, 2024
Merged
1 task
@jdidion jdidion self-assigned this Jun 26, 2024
claymcleod added a commit that referenced this issue Jan 24, 2025
@stxue1 @claymcleod
@jdidion @adamnovak
fix: fixes several issues with tests within the specification
046fd40 
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request in

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
@stxue1 @claymcleod
@jdidion @adamnovak
fix: fixes several issues with tests within the specification
69c0bae 
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
@stxue1 @claymcleod
@jdidion @adamnovak
fix: fixes several issues with tests within the specification
d5fb794 
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdidion jdidion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdidion @stxue1