-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected output in test_struct.wdl unit test does not exist #661
Comments
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
test_struct.wdl
unit test has an expected output oftest_struct.person
, but the workflow itself does not have an output variable namedperson
:wdl/SPEC.md
Lines 1124 to 1136 in 9c0b9cf
I think instead of expecting
test_struct.person
, the right output istest_struct.john
, as that output from the workflow is missing in the expected output json.The text was updated successfully, but these errors were encountered: