Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected output in test_struct.wdl unit test does not exist #661

Open
stxue1 opened this issue Jun 17, 2024 · 0 comments
Open

Expected output in test_struct.wdl unit test does not exist #661

stxue1 opened this issue Jun 17, 2024 · 0 comments
Assignees

Comments

@stxue1
Copy link
Collaborator

stxue1 commented Jun 17, 2024

The test_struct.wdl unit test has an expected output of test_struct.person, but the workflow itself does not have an output variable named person:

wdl/SPEC.md

Lines 1124 to 1136 in 9c0b9cf

output {
Person john = Person {
name: "John",
# it's okay to leave out username since it's optional
account: BankAccount {
account_number: "123456",
routing_number: 300211325,
balance: 3.50,
pin_digits: [1, 2, 3, 4]
}
}
Boolean has_account = defined(john.account)
}

I think instead of expecting test_struct.person, the right output is test_struct.john, as that output from the workflow is missing in the expected output json.

jdidion added a commit that referenced this issue Jun 26, 2024
jdidion added a commit that referenced this issue Jun 26, 2024
@jdidion jdidion self-assigned this Jun 26, 2024
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request in

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants