Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM based docker images #1546

Closed
TimoGlastra opened this issue Dec 9, 2021 · 2 comments
Closed

Support ARM based docker images #1546

TimoGlastra opened this issue Dec 9, 2021 · 2 comments

Comments

@TimoGlastra
Copy link
Contributor

I've recently bought an ARM mac and the experience hasn't been great. Opening this issue to keep track of the status of supporting ARM based images for ACA-Py.

There has been some work done by other Hyperledger maintainers, and also the work in von-network which looks very promising. I'm currently developing on an ubuntu droplet because it was causing me too much headache, but would definitely want to get this resolved in the near future.


(below is copied from maintainers mailing list and may be helpful)

Now that mac arm hardware is pretty common, it is useful to have your
docker images built for arm64 and amd64 architectures. This means that
when mac m1 users run your docker containers, no emulation is needed and
performance is much better.

With lots of help from Ry, I've set up the Hyperledger mac arm runner to
build multiarch docker images. The amd64 image is built on the intel mac
via ssh, using docker buildx, and the arm64 image is built on the arm mac
itself.

To make this work via github actions, simply set your runs-on: to
macos-arm and run:

docker buildx build . \
        --push \
        -t ghcr.io/hyperledger-labs/solang:latest \
        --platform linux/arm64,linux/amd64

This results in a single docker image, which contains both the arm64 and
the amd64 layers. You can see the resulting docker images here:

https://github.com/hyperledger-labs/solang/pkgs/container/solang

@swcurran
Copy link
Contributor

swcurran commented Dec 9, 2021

I think this issue belongs in here: https://github.com/bcgov/aries-cloudagent-container, which is the source of the images. Looks like we should be able to do that in the script used to produce the tagged releases. I'll take a look at that when we create the 0.7.3 release tag. Does that sound right?

I'm going to open a separate issue on how/where ACA-Py images should be published. I suspect it is time to (a) put the script/process to create the images into ACA-Py itself, and (b) to publish the images to Hyperledger. But as noted -- separate issue.

@swcurran
Copy link
Contributor

swcurran commented Jun 3, 2022

Closing this in favour of #1548 .

@swcurran swcurran closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants