fix exception loading pickup / drop off for a leg if the stop is skipped in GTFS GraphQL API #6291
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6291 +/- ##
=============================================
+ Coverage 69.75% 69.77% +0.02%
- Complexity 17747 17779 +32
=============================================
Files 2010 2017 +7
Lines 75948 76046 +98
Branches 7784 7785 +1
=============================================
+ Hits 52979 53064 +85
- Misses 20260 20277 +17
+ Partials 2709 2705 -4 ☔ View full report in Codecov by Sentry. |
|
Ok I'll leave this as a draft then and won't publish it, and wait until #5393 is merged. I just need this as an urgent fix to my deployment to tell the user that your train will now skip your stop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix exception loading pickup / drop off for a leg if the stop is skipped. It attempts to directly map the internal
PickDropname into the API but the API doesn't have a value for cancelled (which it usesnullfor the purpose).Issue
Fixes #6290
Unit tests
TBD
Documentation
None, bug fix only.
Changelog