-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make motorroad=yes
car-only
#6288
Merged
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:motorroad
Dec 3, 2024
Merged
Make motorroad=yes
car-only
#6288
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:motorroad
Dec 3, 2024
+71
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6288 +/- ##
=============================================
+ Coverage 69.76% 69.79% +0.02%
- Complexity 17750 17785 +35
=============================================
Files 2010 2017 +7
Lines 75948 76042 +94
Branches 7784 7781 -3
=============================================
+ Hits 52983 53071 +88
- Misses 20257 20266 +9
+ Partials 2708 2705 -3 ☔ View full report in Codecov by Sentry. |
@vesameskanen Can you review this? |
vesameskanen
previously approved these changes
Nov 28, 2024
@eibakke Can I ask you to review this one? If not let me know and I will reassign. |
eibakke
reviewed
Dec 3, 2024
application/src/main/java/org/opentripplanner/osm/tagmapping/OsmTagMapper.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/osm/tagmapping/FinlandMapper.java
Show resolved
Hide resolved
eibakke
approved these changes
Dec 3, 2024
vesameskanen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make OSM ways tagged with
motorroad=yes
car-only.Before
After
Issue
Closes #6287
Unit tests
Added.
Documentation
Autogenerated.