VehiclePosition can't be processed for an ADDED trip

[miklcct]

Expected behavior

The VehiclePosition can be matched for an ADDED trip.

Observed behavior

The VehiclePosition fails to process with a warning logged:

17:00:16.295 WARN [graph-writer]  (ResultLogger.java:46) [feedId=NR type=gtfs-rt-vehicle-positions] 6 failures of errorType=TRIP_NOT_FOUND_IN_PATTERN: [NR:O01947_20241017, NR:O01941_20241017, NR:O01898_20241017, NR:O01951_20241017, NR:O01948_20241017, NR:O01950_20241017]

In the above example, O01947_20241017 is an added trip added in the same GTFS-RT feed.

Version of OTP used (exact commit hash or JAR name)

2.7.0-SNAPSHOT

Data sets in use (links to GTFS and OSM PBF files)

National Rail GTFS with GTFS-RT update.

Command line used to start OTP

/home/aubin/jdk/bin/java -jar /home/aubin/opentripplanner/otp-shaded.jar --load --serve /home/aubin/opentripplanner

Router config and graph build config JSON

router-config.json

{
  "routingDefaults": {
    "drivingDirection": "left",
    "locale": "en_GB",
    "numItineraries": 10,
    "searchWindow": "PT6H",
    "transferSlack": "PT30S",
    "waitReluctance": 1.76,
    "accessEgress": {
      "maxDuration": "PT2H"
    },
    "walk": {
      "boardCost": 300,
      "reluctance": 1.68
    },
    "wheelchairAccessibility": {
      "trip": {
        "onlyConsiderAccessible": false,
        "unknownCost": 600,
        "inaccessibleCost": 3600
      },
      "stop": {
        "onlyConsiderAccessible": false,
        "unknownCost": 600,
        "inaccessibleCost": 3600
      },
      "elevator": {
        "onlyConsiderAccessible": false
      },
      "inaccessibleStreetReluctance": 25,
      "maxSlope": 0.08333,
      "slopeExceededReluctance": 50,
      "stairsReluctance": 25
    }
  },
  "timetableUpdates": {
    "maxSnapshotFrequency": "PT5S"
  },
  "transit": {
    "searchThreadPoolSize": 4,
    "transferCacheRequests": [
      {
        "modes" : "WALK",
        "walk" : {
          "boardCost" : 300,
          "reluctance" : 1.68
        }
      }
    ]
  },
  "updaters": [
    {
      "type": "real-time-alerts",
      "url": "${NR_GTFSRT_URL}",
      "feedId" : "NR",
      "frequency": "PT1M"
    },
    {
      "type": "stop-time-updater",
      "url": "${NR_GTFSRT_URL}",
      "feedId" : "NR",
      "frequency": "PT43S"
    },
    {
      "type" : "vehicle-positions",
      "url" : "${NR_GTFSRT_URL}",
      "feedId" : "NR",
      "frequency" : "PT34S",
      "fuzzyTripMatching" : false,
      "features" : [
        "position",
        "stop-position",
        "occupancy"
      ]
    },
    {
      "type" : "vehicle-positions",
      "url" : "https://internal-proxy.servology.co.uk/dft/bus-data/gtfsrt/",
      "feedId" : "DfT",
      "frequency" : "PT26S",
      "fuzzyTripMatching" : false,
      "features" : [
        "position",
        "stop-position",
        "occupancy"
      ]
    }
  ]
}

Steps to reproduce the problem

Produce a GTFS-RT feed which contains an added journey, and a VehiclePosition for that journey, like in the example below:

entity {
  id: "ADD_O01951_20241017"
  trip_update {
    trip {
      trip_id: "O01951_20241017"
      start_time: "16:45:00"
      start_date: "20241017"
      schedule_relationship: ADDED
      route_id: "XC"
    }
    stop_time_update {
      stop_sequence: 0
      arrival {
        delay: 240
        time: 1729180140
      }
      departure {
        delay: 240
        time: 1729180140
      }
      stop_id: "9100DRBY2"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 1
      arrival {
        delay: 180
        time: 1729181160
      }
      departure {
        delay: 120
        time: 1729181220
      }
      stop_id: "9100CHFD1"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 2
      arrival {
        delay: 60
        time: 1729182000
      }
      departure {
        delay: 0
        time: 1729182060
      }
      stop_id: "9100SHEFFLD1B"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 3
      arrival {
        delay: 0
        time: 1729183560
      }
      departure {
        delay: 0
        time: 1729183620
      }
      stop_id: "9100WKFLDWG2"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 4
      arrival {
        delay: 0
        time: 1729184460
      }
      departure {
        delay: 0
        time: 1729184880
      }
      stop_id: "9100LEEDS"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 5
      arrival {
        delay: 0
        time: 1729186200
      }
      departure {
        delay: 0
        time: 1729186320
      }
      stop_id: "9100YORK10"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 6
      arrival {
        delay: 0
        time: 1729187940
      }
      departure {
        delay: 0
        time: 1729188000
      }
      stop_id: "9100DLTN"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 7
      arrival {
        delay: 0
        time: 1729188960
      }
      departure {
        delay: 0
        time: 1729189020
      }
      stop_id: "9100DRHM"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 8
      arrival {
        delay: 0
        time: 1729189740
      }
      departure {
        delay: 0
        time: 1729190100
      }
      stop_id: "9100NWCSTLE2"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 9
      arrival {
        delay: 0
        time: 1729191540
      }
      departure {
        delay: 0
        time: 1729191660
      }
      stop_id: "9100ALNMOTH2"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 10
      arrival {
        delay: 0
        time: 1729192860
      }
      departure {
        delay: 0
        time: 1729192920
      }
      stop_id: "9100BRWCKUT"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
    stop_time_update {
      stop_sequence: 11
      arrival {
        delay: 0
        time: 1729195440
      }
      departure {
        delay: 0
        time: 1729195440
      }
      stop_id: "9100EDINBUR"
      stop_time_properties {
        [transit_realtime.stop_time_properties] {
          pickup_type: REGULAR
          dropoff_type: REGULAR
        }
      }
    }
  }
}
entity {
  id: "VEHICLE_O01951_20241017_ON_20241017"
  vehicle {
    trip {
      trip_id: "O01951_20241017"
      start_time: "16:45:00"
      start_date: "20241017"
      schedule_relationship: ADDED
      route_id: "XC"
    }
    current_stop_sequence: 1
    current_status: STOPPED_AT
    timestamp: 1729181160
  }
}