No CAR_RENTAL with allowKeepingAtDestination

[hbruch]

Expected behavior

When searching a CAR_RENTAL journey for a feed with allowKeepingRentedVehicleAtDestination/allowKeepingAtDestination enabled, OTP should return a WALK/CAR journey, given there is a vehicleRentalStation with cars available at the origin.

Observed behavior

OTP only returns a WALK suggestion.

Version of OTP used (exact commit hash or JAR name)

9554487

Data sets in use (links to GTFS and OSM PBF files)

http://download.geofabrik.de/europe/germany/brandenburg-latest.osm.pbf
https://data.mfdz.de/gbfs/zegg_badbelzig/gbfs.json

Router config and graph build config JSON

router-config.json:

{
  "routingDefaults": {
     "car": {
      "rental": {
        "useAvailabilityInformation": false,
        "allowKeepingAtDestination": true
      }
    }
  },
  "updaters": [
    {
      "type": "vehicle-rental",
      "sourceType": "gbfs",
      "frequency": "15m",
      "allowKeepingRentedVehicleAtDestination": true,
      "url": "https://data.mfdz.de/gbfs/zegg_badbelzig/gbfs.json"
    }
  ]
}

Steps to reproduce the problem

CAR_RENTAL-Request

Analysis

Performing the same query with CAR mode returns a response with a single CAR leg.

To me, it looks like the issue is that for CAR_RENTAL, StreetIndex.getTraverseModeForLinker returns WALK as nonTransitMode for the endVertex, which prevents reaching the final toVertex with a rented car.

I suggest to change StreetIndex.getTraverseModeForLinker as follows, though I'm not sure if this would then prevent returning the car at a station close to the destination...

private TraverseMode getTraverseModeForLinker(StreetMode streetMode, boolean endVertex) {
    TraverseMode nonTransitMode = TraverseMode.WALK;
    // for park and ride we will start in car mode and walk to the end vertex
    boolean parkAndRideDepart = streetMode == StreetMode.CAR_TO_PARK && !endVertex;
    // for car rental, we want to allow keeping the car at destination
    boolean carRentalArrival = streetMode == StreetMode.CAR_RENTAL && endVertex;
    boolean onlyCarAvailable = streetMode == StreetMode.CAR;
    if (onlyCarAvailable || parkAndRideDepart || carRentalArrival) {
      nonTransitMode = TraverseMode.CAR;
    }
    return nonTransitMode;
  }

EDIT:
This issue seem to occur in the special case that the edge closest to the destination is a walk/bike only edge, as it is the case for destination https://www.openstreetmap.org/node/4819679118 :

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days