You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When searching a CAR_RENTAL journey for a feed with allowKeepingRentedVehicleAtDestination/allowKeepingAtDestination enabled, OTP should return a WALK/CAR journey, given there is a vehicleRentalStation with cars available at the origin.
Observed behavior
OTP only returns a WALK suggestion.
Version of OTP used (exact commit hash or JAR name)
Performing the same query with CAR mode returns a response with a single CAR leg.
To me, it looks like the issue is that for CAR_RENTAL, StreetIndex.getTraverseModeForLinker returns WALK as nonTransitMode for the endVertex, which prevents reaching the final toVertex with a rented car.
I suggest to change StreetIndex.getTraverseModeForLinker as follows, though I'm not sure if this would then prevent returning the car at a station close to the destination...
privateTraverseModegetTraverseModeForLinker(StreetModestreetMode, booleanendVertex) {
TraverseModenonTransitMode = TraverseMode.WALK;
// for park and ride we will start in car mode and walk to the end vertexbooleanparkAndRideDepart = streetMode == StreetMode.CAR_TO_PARK && !endVertex;
// for car rental, we want to allow keeping the car at destinationbooleancarRentalArrival = streetMode == StreetMode.CAR_RENTAL && endVertex;
booleanonlyCarAvailable = streetMode == StreetMode.CAR;
if (onlyCarAvailable || parkAndRideDepart || carRentalArrival) {
nonTransitMode = TraverseMode.CAR;
}
returnnonTransitMode;
}
EDIT:
This issue seem to occur in the special case that the edge closest to the destination is a walk/bike only edge, as it is the case for destination https://www.openstreetmap.org/node/4819679118 :
The text was updated successfully, but these errors were encountered:
Expected behavior
When searching a
CAR_RENTAL
journey for a feed withallowKeepingRentedVehicleAtDestination
/allowKeepingAtDestination
enabled, OTP should return a WALK/CAR journey, given there is a vehicleRentalStation with cars available at the origin.Observed behavior
OTP only returns a
WALK
suggestion.Version of OTP used (exact commit hash or JAR name)
9554487
Data sets in use (links to GTFS and OSM PBF files)
http://download.geofabrik.de/europe/germany/brandenburg-latest.osm.pbf
https://data.mfdz.de/gbfs/zegg_badbelzig/gbfs.json
Router config and graph build config JSON
router-config.json:
Steps to reproduce the problem
CAR_RENTAL-Request
Analysis
Performing the same query with CAR mode returns a response with a single CAR leg.
To me, it looks like the issue is that for CAR_RENTAL,
StreetIndex.getTraverseModeForLinker
returnsWALK
asnonTransitMode
for the endVertex, which prevents reaching the final toVertex with a rented car.I suggest to change
StreetIndex.getTraverseModeForLinker
as follows, though I'm not sure if this would then prevent returning the car at a station close to the destination...EDIT:
This issue seem to occur in the special case that the edge closest to the destination is a walk/bike only edge, as it is the case for destination https://www.openstreetmap.org/node/4819679118 :
The text was updated successfully, but these errors were encountered: