refactor: Correct spelling of 'Realtime' in IncludeStopsUsedRealTimeInTransfers

t2gran · t2gran · commit 7afaba162588 · 2025-11-18T01:06:11.000+01:00
diff --git a/application/src/main/java/org/opentripplanner/framework/application/OTPFeature.java b/application/src/main/java/org/opentripplanner/framework/application/OTPFeature.java
@@ -43,7 +43,7 @@ public enum OTPFeature {
   ),
   FloatingBike(true, false, "Enable floating bike routing."),
   GtfsGraphQlApi(true, false, "Enable the [GTFS GraphQL API](apis/GTFS-GraphQL-API.md)."),
-  IncludeStopsUsedRealtimeInTransfers(
+  IncludeStopsUsedRealTimeInTransfers(
     false,
     false,
     """
diff --git a/application/src/main/java/org/opentripplanner/graph_builder/module/transfer/filter/PatternNearbyStopFilter.java b/application/src/main/java/org/opentripplanner/graph_builder/module/transfer/filter/PatternNearbyStopFilter.java
@@ -82,6 +82,6 @@ private List<FeedScopedId> findPatternsForStop(RegularStop stop, boolean reverse
   }
 
   private boolean includeStopUsedRealtime(RegularStop stop) {
-    return OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn() && stop.isSometimesUsedRealtime();
+    return OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn() && stop.isSometimesUsedRealtime();
   }
 }
diff --git a/application/src/main/java/org/opentripplanner/gtfs/mapping/StopMapper.java b/application/src/main/java/org/opentripplanner/gtfs/mapping/StopMapper.java
@@ -110,7 +110,7 @@ private RegularStop doMap(org.onebusaway.gtfs.model.Stop gtfsStop) {
    * when it does not have any trips/routes visiting it.
    */
   private static boolean mapSometimesUsedRealtime(TransitMode mode, Stop gtfsStop) {
-    if (OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn()) {
+    if (OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn()) {
       if (mode == TransitMode.RAIL) {
         return true;
       }
diff --git a/application/src/main/java/org/opentripplanner/netex/mapping/QuayMapper.java b/application/src/main/java/org/opentripplanner/netex/mapping/QuayMapper.java
@@ -79,7 +79,7 @@ private RegularStop map(
     String subMode = transitMode.subMode();
     boolean sometimesUsedRealtime = false;
 
-    if (OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn()) {
+    if (OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn()) {
       if (transitMode.mainMode() == RAIL) {
         sometimesUsedRealtime = true;
       }
diff --git a/application/src/test/java/org/opentripplanner/graph_builder/module/transfer/DirectTransferGeneratorTest.java b/application/src/test/java/org/opentripplanner/graph_builder/module/transfer/DirectTransferGeneratorTest.java
@@ -197,7 +197,7 @@ public void testStreetTransfersWithPatterns() {
 
   @Test
   public void testStreetTransfersWithPatternsIncludeRealTimeUsedStops() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       var repository = DirectTransferGeneratorTestData.of()
         .withPatterns()
         .withStreetGraph()
@@ -250,7 +250,7 @@ public void testStreetTransfersWithMultipleRequestsWithPatterns() {
 
   @Test
   public void testStreetTransfersWithStationWithTransfersNotAllowed() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       var repository = DirectTransferGeneratorTestData.of()
         .withPatterns()
         .withStreetGraph()
@@ -279,7 +279,7 @@ public void testStreetTransfersWithStationWithTransfersNotAllowed() {
 
   @Test
   public void testBikeRequestWithBikesAllowedTransfersWithIncludeEmptyRailStopsInTransfersOn() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       var repository = DirectTransferGeneratorTestData.of()
         .withPatterns()
         .withStreetGraph()
diff --git a/application/src/test/java/org/opentripplanner/gtfs/mapping/StopMapperTest.java b/application/src/test/java/org/opentripplanner/gtfs/mapping/StopMapperTest.java
@@ -197,7 +197,7 @@ void testMapWithPlatformCode() {
 
   @Test
   void testMapSometimesUsedRealtimeForRailWithFeatureOn() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       Stop input = createBasicStop();
       input.setVehicleType(VEHICLE_TYPE_RAIL);
 
@@ -209,7 +209,7 @@ void testMapSometimesUsedRealtimeForRailWithFeatureOn() {
 
   @Test
   void testMapSometimesUsedRealtimeForRailReplacementBusWithFeatureOn() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       Stop input = createBasicStop();
       input.setVehicleType(VEHICLE_TYPE_RAIL_REPLACEMENT_BUS);
 
@@ -221,7 +221,7 @@ void testMapSometimesUsedRealtimeForRailReplacementBusWithFeatureOn() {
 
   @Test
   void testMapSometimesUsedRealtimeForBusWithFeatureOn() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOn(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOn(() -> {
       Stop input = createBasicStop();
       input.setVehicleType(VEHICLE_TYPE_BUS);
 
@@ -233,7 +233,7 @@ void testMapSometimesUsedRealtimeForBusWithFeatureOn() {
 
   @Test
   void testMapSometimesUsedRealtimeWithFeatureOff() {
-    OTPFeature.IncludeStopsUsedRealtimeInTransfers.testOff(() -> {
+    OTPFeature.IncludeStopsUsedRealTimeInTransfers.testOff(() -> {
       Stop input = createBasicStop();
       input.setVehicleType(VEHICLE_TYPE_RAIL);
 
diff --git a/doc/user/Configuration.md b/doc/user/Configuration.md
@@ -232,7 +232,7 @@ Here is a list of all features which can be toggled on/off and their default val
 | `ExtraTransferLegOnSameStop`          | Should there be a transfer leg when transferring on the very same stop. Note that for in-seat/interlined transfers no transfer leg will be generated.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 |                    |         |
 | `FloatingBike`                        | Enable floating bike routing.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         |         ✓️         |         |
 | `GtfsGraphQlApi`                      | Enable the [GTFS GraphQL API](apis/GTFS-GraphQL-API.md).                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              |         ✓️         |         |
-| `IncludeStopsUsedRealtimeInTransfers` | When generating transfers, stops without any patterns are excluded to improve performance if `ConsiderPatternsForDirectTransfers` is enabled. However, some stops are only used by trips changed or added by real-time updates. Since transfer generation happens before real-time updates are applied, OTP cannot know which stops will be needed. Instead, OTP will attempt to identify stops likely to be used by real-time updates at import time. Common cases include rail stops (which often have late platform assignments) and stops reserved for replacement services (which can be detected in NeTEx by examining the stop sub-mode). This feature has no effect if `ConsiderPatternsForDirectTransfers` is disabled.  This feature is only supported for NeTEx feeds, not for GTFS feeds. |                    |         |
+| `IncludeStopsUsedRealTimeInTransfers` | When generating transfers, stops without any patterns are excluded to improve performance if `ConsiderPatternsForDirectTransfers` is enabled. However, some stops are only used by trips changed or added by real-time updates. Since transfer generation happens before real-time updates are applied, OTP cannot know which stops will be needed. Instead, OTP will attempt to identify stops likely to be used by real-time updates at import time. Common cases include rail stops (which often have late platform assignments) and stops reserved for replacement services (which can be detected in NeTEx by examining the stop sub-mode). This feature has no effect if `ConsiderPatternsForDirectTransfers` is disabled.  This feature is only supported for NeTEx feeds, not for GTFS feeds. |                    |         |
 | `MinimumTransferTimeIsDefinitive`     | If the minimum transfer time is a lower bound (default) or the definitive time for the transfer. Set this to `true` if you want to set a transfer time lower than what OTP derives from OSM data.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |                    |         |
 | `OnDemandRaptorTransfer`              | Calculate transfers only when accessed by Raptor, instead of calculating and caching all transfers for the whole graph, for runtime requests which are not pre-cached in `transferCacheRequests` in router-config.json. This may help performance when doing local journey planning in a large graph.  Requests which are specified in `transferCacheRequests` in router-config.json are not affected and are always pre-cached for the whole graph.                                                                                                                                                                                                                                                                                                                                                  |                    |         |
 | `OptimizeTransfers`                   | OTP will inspect all itineraries found and optimize where (which stops) the transfer will happen. Waiting time, priority and guaranteed transfers are taken into account.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |         ✓️         |         |

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,6 @@ private List<FeedScopedId> findPatternsForStop(RegularStop stop, boolean reverse`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`private boolean includeStopUsedRealtime(RegularStop stop) {`
`85`		`- return OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn() && stop.isSometimesUsedRealtime();`
	`85`	`+ return OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn() && stop.isSometimesUsedRealtime();`
`86`	`86`	`}`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ private RegularStop doMap(org.onebusaway.gtfs.model.Stop gtfsStop) {`
`110`	`110`	`* when it does not have any trips/routes visiting it.`
`111`	`111`	`*/`
`112`	`112`	`private static boolean mapSometimesUsedRealtime(TransitMode mode, Stop gtfsStop) {`
`113`		`- if (OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn()) {`
	`113`	`+ if (OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn()) {`
`114`	`114`	`if (mode == TransitMode.RAIL) {`
`115`	`115`	`return true;`
`116`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ private RegularStop map(`
`79`	`79`	`String subMode = transitMode.subMode();`
`80`	`80`	`boolean sometimesUsedRealtime = false;`
`81`	`81`
`82`		`- if (OTPFeature.IncludeStopsUsedRealtimeInTransfers.isOn()) {`
	`82`	`+ if (OTPFeature.IncludeStopsUsedRealTimeInTransfers.isOn()) {`
`83`	`83`	`if (transitMode.mainMode() == RAIL) {`
`84`	`84`	`sometimesUsedRealtime = true;`
`85`	`85`	`}`