Fine-tune tests

Author: leonardehrenfried

application/src/ext-test/java/org/opentripplanner/ext/fares/impl/gtfs/TimeLimitEvaluatorTest.java

@@ -51,10 +51,10 @@ void withinLimit(TimeLimitType type, Duration duration) {
 
   private static List<Arguments> belowLimitCases() {
     return List.of(
-      Arguments.of(DEPARTURE_TO_ARRIVAL, ofMinutes(19)),
+      Arguments.of(DEPARTURE_TO_ARRIVAL, ofMinutes(20).minusSeconds(20)),
       Arguments.of(DEPARTURE_TO_DEPARTURE, ofMinutes(10).minusSeconds(1)),
       Arguments.of(ARRIVAL_TO_ARRIVAL, ofMinutes(15).minusSeconds(1)),
-      Arguments.of(ARRIVAL_TO_DEPARTURE, ofMinutes(4))
+      Arguments.of(ARRIVAL_TO_DEPARTURE, ofMinutes(5).minusSeconds(1))
     );
   }
 

application/src/ext/java/org/opentripplanner/ext/fares/model/TimeLimitType.java

@@ -15,13 +15,13 @@ public enum TimeLimitType {
    */
   DEPARTURE_TO_DEPARTURE,
   /**
-   * The duration is to be computed from the arrival time of the current leg to the arrival time of
+   * The duration is to be computed from the arrival time of the current leg to the departure time of
    * the next one.
    */
-  ARRIVAL_TO_ARRIVAL,
+  ARRIVAL_TO_DEPARTURE,
   /**
-   * The duration is to be computed from the arrival time of the current leg to the departure time of
+   * The duration is to be computed from the arrival time of the current leg to the arrival time of
    * the next one.
    */
-  ARRIVAL_TO_DEPARTURE,
+  ARRIVAL_TO_ARRIVAL,
 }

application/src/test/java/org/opentripplanner/gtfs/mapping/FareTransferRuleMapperTest.java

@@ -68,6 +68,8 @@ void timeLimit() {
   void limitType() {
     assertEquals(TimeLimitType.DEPARTURE_TO_ARRIVAL, FareTransferRuleMapper.mapLimitType(0));
     assertEquals(TimeLimitType.DEPARTURE_TO_DEPARTURE, FareTransferRuleMapper.mapLimitType(1));
+    assertEquals(TimeLimitType.ARRIVAL_TO_DEPARTURE, FareTransferRuleMapper.mapLimitType(2));
+    assertEquals(TimeLimitType.ARRIVAL_TO_ARRIVAL, FareTransferRuleMapper.mapLimitType(3));
   }
 
   @Test