Convert to List

Author: leonardehrenfried

application/src/main/java/org/opentripplanner/transit/service/TransitService.java

@@ -168,11 +168,8 @@ public interface TransitService {
    * are returned. If the id matches a regular stop, area stop or stop group, then a list with one
    * item is returned.
    */
-  default Set<FeedScopedId> findStopOrChildIds(FeedScopedId id) {
-    return findStopOrChildStops(id)
-      .stream()
-      .map(StopLocation::getId)
-      .collect(Collectors.toUnmodifiableSet());
+  default List<FeedScopedId> findStopOrChildIds(FeedScopedId id) {
+    return findStopOrChildStops(id).stream().map(StopLocation::getId).distinct().toList();
   }
 
   Collection<StopLocationsGroup> listStopLocationGroups();

application/src/test/java/org/opentripplanner/transit/service/DefaultTransitServiceTest.java

@@ -1,5 +1,6 @@
 package org.opentripplanner.transit.service;
 
+import static com.google.common.truth.Truth.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -337,24 +338,24 @@ void hasTripsForStop() {
   @Test
   void stopOrChildId() {
     var res = service.findStopOrChildIds(STOP_A.getId());
-    assertEquals(Set.of(STOP_A.getId()), res);
+    assertThat(res).containsExactly(STOP_A.getId());
   }
 
   @Test
   void stationChildIds() {
     var res = service.findStopOrChildIds(STATION.getId());
-    assertEquals(Set.of(STOP_A.getId(), STOP_B.getId()), res);
+    assertThat(res).containsExactly(STOP_A.getId(), STOP_B.getId());
   }
 
   @Test
   void multiModalStationChildIds() {
     var res = service.findStopOrChildIds(MM_STATION.getId());
-    assertEquals(Set.of(STOP_A.getId(), STOP_B.getId()), res);
+    assertThat(res).containsExactly(STOP_A.getId(), STOP_B.getId());
   }
 
   @Test
   void groupOfStationsChildIds() {
     var res = service.findStopOrChildIds(GO_STATIONS.getId());
-    assertEquals(Set.of(STOP_A.getId(), STOP_B.getId()), res);
+    assertThat(res).containsExactly(STOP_A.getId(), STOP_B.getId());
   }
 }