-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-time speed #3
Comments
Ok! I've updated the docs and proto buff message spec to handle both baseline and current conditions. Curious to hear your thoughts. |
On the Why not having a dedicated message for each bin, such as this: message SpeedQuartiles {
required float averageSpeed = 1;
optional float topQuartileSpeed = 2;
optional float bottomQuartileSpeed = 3;
}
message BaselineStats {
required SegmentDefinition segment = 1;
required float averageSpeed = 2;
repeated BinStats hourOfWeek = 3;
} Just a small note: if we have both |
About current condition, should the Also, providing both start/end 64 bits timestamps require lots of bandwith, maybe only a start plus offset; and/or a 32 bits seconds timestamp, or even shorter, two offsets to a global message "current" timestamp. |
Agreed that if we are including quartiles, we should include the median rather than the mean. I see the column-store format (arrays containing all measurements for all hours of the week) as mainly a space optimization. If we're not aiming for maximum compactness then it is indeed clearer to have one "struct" (compound protobuf message) per hour, with all the quantile fields present in each of those messages. Here we have a dichotomy between historical data over all hours of the week, versus current data for only the segments where we have observations. This implies that data consumers will always handle all prediction and interpolation, which is unlikely, so there does need to be a way to express full-dataset predicted results where the inference/interpolation is done by the producer. From what I've read "required" fields in Protobuf are essentially deprecated as they have been found to cause unexpected fragility, so I'd be in favor of just avoiding required fields. |
Unless I'm mistaken, there is no "real-time current speed" information in the format. Shouldn't we have this information on the format too?
We could also think on a predicted speed(s), if available.
The text was updated successfully, but these errors were encountered: