You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 23, 2023. It is now read-only.
As far as I can tell, the default is now simply that every span is set as active when .started. Regardless, the docs should be changed to reflect the latest version.
This is not the only issue with the docs, there are also numerous other examples of outdated example code (in the "Scopes" doc or other sections of the docs).
I'm aware that OpenTracing is merging with OpenCensus into OpenTelemetry, but I don't think that's an "excuse" for incorrect documentation (insofar as voluntary contributors have to make "excuses").
The text was updated successfully, but these errors were encountered:
Given the changes, I'm trying to think under what conditions one would want to manage a scope's lifecycle. Is there any need to pay attention to it now?
Scopes are optional and users should be very interested in controlling the timeframe in which a span is active. It's not something that anyone should ignore.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The "Scopes" doc references
Tracer.SpanBuilder.startActiveSpan(boolean finishOnClose)
, which does not match the latest version of OpenTracing.As far as I can tell, the default is now simply that every span is set as active when
.start
ed. Regardless, the docs should be changed to reflect the latest version.This is not the only issue with the docs, there are also numerous other examples of outdated example code (in the "Scopes" doc or other sections of the docs).
I'm aware that OpenTracing is merging with OpenCensus into OpenTelemetry, but I don't think that's an "excuse" for incorrect documentation (insofar as voluntary contributors have to make "excuses").
The text was updated successfully, but these errors were encountered: