Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

MockTracer.reset doesn't appear to work all cases #356

Open
mdedetrich opened this issue Jul 14, 2019 · 1 comment
Open

MockTracer.reset doesn't appear to work all cases #356

mdedetrich opened this issue Jul 14, 2019 · 1 comment

Comments

@mdedetrich
Copy link

From the PR here opentracing-contrib/scala-concurrent#7 it appears that in some cases MockTracer.reset() doesn't appear to clear all spans, quoting the PR.

Note that for some reason, one test is still failing, i.e.

  • testNoActiveSpan *** FAILED ***
    {traceId:1, spanId:2, parentId:0, operationName:"one"} did not equal null (TracedExecutionContextTest.scala:75)

For some reason the testPropagation test is leaving over the span and its not getting reset by mockTracer.reset(), do you have any idea what could be going on here?

You can use mvn:test to reproduce the problem.

@yurishkuro
Copy link
Member

Perhaps you have a race condition in your code, where some span is getting finish()-ed after reset() is called.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants