You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 23, 2023. It is now read-only.
I am trying to use MockTracer for unit testing.
For this I execute my application and then validate the contents of MockTracer.finishedSpans().
For 0.32 I modified my application to take advantage of the new Tracer.close() method to properly free Tracer resources.
This broke the tests because on closing the MockTracer its finishedSpans are reset.
I would argue that
Closing the tracer should not reset the finishedSpans
The internal isClosed member should be accessible to users of MockTracer to ensure that the tracer has been properly closed.
The text was updated successfully, but these errors were encountered:
t-8ch
changed the title
MockTracer.close() clear finishedSpans
MockTracer.close() clears finishedSpans
Apr 30, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I am trying to use
MockTracer
for unit testing.For this I execute my application and then validate the contents of
MockTracer.finishedSpans()
.For 0.32 I modified my application to take advantage of the new
Tracer.close()
method to properly freeTracer
resources.This broke the tests because on closing the
MockTracer
itsfinishedSpans
are reset.I would argue that
finishedSpans
isClosed
member should be accessible to users ofMockTracer
to ensure that the tracer has been properly closed.The text was updated successfully, but these errors were encountered: