Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

MockTracer.close() clears finishedSpans #346

Open
t-8ch opened this issue Apr 30, 2019 · 0 comments
Open

MockTracer.close() clears finishedSpans #346

t-8ch opened this issue Apr 30, 2019 · 0 comments

Comments

@t-8ch
Copy link

t-8ch commented Apr 30, 2019

I am trying to use MockTracer for unit testing.
For this I execute my application and then validate the contents of MockTracer.finishedSpans().
For 0.32 I modified my application to take advantage of the new Tracer.close() method to properly free Tracer resources.
This broke the tests because on closing the MockTracer its finishedSpans are reset.

I would argue that

  • Closing the tracer should not reset the finishedSpans
  • The internal isClosed member should be accessible to users of MockTracer to ensure that the tracer has been properly closed.
@t-8ch t-8ch changed the title MockTracer.close() clear finishedSpans MockTracer.close() clears finishedSpans Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant