Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Things left out of SpanContext #341

Open
codefromthecrypt opened this issue Apr 2, 2019 · 0 comments
Open

Things left out of SpanContext #341

codefromthecrypt opened this issue Apr 2, 2019 · 0 comments

Comments

@codefromthecrypt
Copy link
Contributor

While traceId and spanId were recently added to the SpanContext type, routine properties used including parentSpanId and sampling status were left out.

I can cite code back to at least 2012 that uses these properties as well new and different code such as census which exposes the sampling status.

The impact is that usage of the span context will still remain tracer specific. I'm pretty sure you knew this, but I wanted to explicitly make an issue so folks can know why you decided to leave them out.

PS sampling api is still missing from OT, but we are supposed to interpret SAMPLING_PRIORITY the same as if a sampling api call was made, so I think it is relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant