-
Notifications
You must be signed in to change notification settings - Fork 312
fix: hot and new icon fill cannot transparent transmission #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughFour new icon identifiers related to "hot" and "new" badges in both Chinese and English are added to the symbol icon group. Additionally, two Vue icon component modules are updated to export "hot" badge icons instead of "new" badge icons, aligning their imports and component names accordingly. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/icon/iconGroups.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue-icon/src/badge-hot-cn/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue-icon/src/badge-hot-en/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/sites/demos/pc/app/icon/iconGroups.js (1)
391-395
: Array maintenance nit – keep theSymbol
list alphabetised to ease future mergesThe four new identifiers work, but the list is already long and manual inserts become error-prone. Consider alphabetising (or at least grouping the Badge icons together) to reduce merge conflicts and lookup time.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (8)
packages/theme-saas/src/svgs/badge-hot-cn.svg
is excluded by!**/*.svg
packages/theme-saas/src/svgs/badge-hot-en.svg
is excluded by!**/*.svg
packages/theme-saas/src/svgs/badge-new-cn.svg
is excluded by!**/*.svg
packages/theme-saas/src/svgs/badge-new-en.svg
is excluded by!**/*.svg
packages/theme/src/svgs/badge-hot-cn.svg
is excluded by!**/*.svg
packages/theme/src/svgs/badge-hot-en.svg
is excluded by!**/*.svg
packages/theme/src/svgs/badge-new-cn.svg
is excluded by!**/*.svg
packages/theme/src/svgs/badge-new-en.svg
is excluded by!**/*.svg
📒 Files selected for processing (3)
examples/sites/demos/pc/app/icon/iconGroups.js
(1 hunks)packages/vue-icon/src/badge-hot-cn/index.ts
(1 hunks)packages/vue-icon/src/badge-hot-en/index.ts
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
packages/vue-icon/src/badge-hot-cn/index.ts (3)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-histogram/src/chart-histogram.vue:33-36
Timestamp: 2024-11-25T03:43:05.285Z
Learning: 在 Tiny Vue 代码库中,使用 `chart-core` 中的 `huiChartOption` 的组件,不应在其 `data` 中定义 `huiChartOption` 或 `option`,而是应该依赖 `chart-core` 提供的 `huiChartOption`。
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-heatmap/src/chart-heatmap.vue:38-40
Timestamp: 2024-11-25T03:43:19.322Z
Learning: 在 Vue.js 组件(如 `chart-heatmap.vue`)中,使用来自 `chart-core` 的 `huiChartOption` 来管理图表选项,不要在 `data()` 中声明 `option`。
🧬 Code Graph Analysis (2)
packages/vue-icon/src/badge-hot-cn/index.ts (3)
packages/vue-icon/src/badge-hot-en/index.ts (1)
svg
(15-15)packages/vue-icon/src/badge-new-cn/index.ts (1)
svg
(15-15)packages/vue-icon/src/badge-new-en/index.ts (1)
svg
(15-15)
packages/vue-icon/src/badge-hot-en/index.ts (3)
packages/vue-icon/src/badge-hot-cn/index.ts (1)
svg
(15-15)packages/vue-icon/src/badge-new-cn/index.ts (1)
svg
(15-15)packages/vue-icon/src/badge-new-en/index.ts (1)
svg
(15-15)
🔇 Additional comments (2)
packages/vue-icon/src/badge-hot-cn/index.ts (1)
13-15
: Verified SVG Asset and Re-Export
- packages/theme/src/svgs/badge-hot-cn.svg and packages/theme-saas/src/svgs/badge-hot-cn.svg both exist.
- packages/vue-icon/index.ts imports and re-exports
IconBadgeHotCn
(lines 41, 768–769, 1718).- The SVG hook in
packages/vue-icon/src/badge-hot-cn/index.ts
is correctly wired.No further changes required.
packages/vue-icon/src/badge-hot-en/index.ts (1)
13-15
: All checks passed for the English “hot” badge icon
- The SVG asset
badge-hot-en.svg
is present under
•packages/theme/src/svgs/badge-hot-en.svg
•packages/theme-saas/src/svgs/badge-hot-en.svg
- The Vue icon package correctly imports and re-exports
IconBadgeHotEn
inpackages/vue-icon/index.ts
(import at line 42; exported at lines 770–771, 1719)No further changes needed.
PR
fix:hot和new图标fill无法透传,以及图标引用错误
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes