Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GRPCGateway loopback call with IPC call #2004

Closed
jrschumacher opened this issue Mar 25, 2025 · 0 comments · Fixed by #2005
Closed

Replace GRPCGateway loopback call with IPC call #2004

jrschumacher opened this issue Mar 25, 2025 · 0 comments · Fixed by #2005
Assignees
@jrschumacher
Labels
bug Something isn't working

Comments

@jrschumacher
Copy link
Member

When adding ConnectRPC support #1524 deprecated support of GRPCGateway was enabled through a loopback call. This worked fine when running the server with servicemesh TLS termination, but when running with TLS termination at the server the loopback request would fail due to service name mismatch.

To resolve this, we need to update the GRPCGateway registration to use the in-process connection.
@jrschumacher jrschumacher added the bug Something isn't working label Mar 25, 2025
@jrschumacher jrschumacher self-assigned this Mar 25, 2025
jrschumacher added a commit that referenced this issue Mar 25, 2025
@jrschumacher
fix(core): update GRPC Gateway to use IPC

Verified

This commit was signed with the committer’s verified signature.
jrschumacher Ryan Schumacher
SSH Key Fingerprint: FC8qHJKBW7pYnC2jd+UoZafHkpIkPoZ7vYw0qwX8tKI
Verified
Learn about vigilant mode
Loading
Loading status checks…
f6a3ba2 
Closes #2004
DSPX-593
@jrschumacher jrschumacher mentioned this issue Mar 25, 2025
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2025
@jrschumacher
fix(core)!: update GRPC Gateway to use IPC (#2005)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ff605f4 
Closes #2004
DSPX-593

### Proposed Changes

* Bind GRPCGateway to the ConnectRPC IPC connection

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

![CleanShot 2025-03-25 at 18 21
38](https://github.com/user-attachments/assets/cb92e9b1-bafa-4311-97d0-09e05420a3e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrschumacher jrschumacher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core)!: update GRPC Gateway to use IPC opentdf/platform
1 participant
@jrschumacher