Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing an unmarked crossing to a marked crossing doesn't update the crossing:markings tag to match #1408

Open
une-abeille-osm opened this issue Oct 15, 2024 · 2 comments

Comments

@une-abeille-osm
Copy link

une-abeille-osm commented Oct 15, 2024

URL

https://www.openstreetmap.org/edit

How to reproduce the issue?

Select either a crossing=unmarked node or way, and change it to a marked crossing via the preset search in the sidebar.

This will result in a crossing with the following conflicting tags:

crossing=uncontrolled crossing:markings=no

crossing:markings=yes would match with the standard iD preset for this crossing type.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Firefox

@danieldegroot2
Copy link
Contributor

See #658 (comment)

(See also #1201 for work being done to improve crossing behaviour in iD.)

@tyrasd
Copy link
Member

tyrasd commented Dec 17, 2024

Tricky… the current workflow when changing a preset is programmed to keep a tag value if the new preset has a field for the corresponding tag key (e.g. when changing a building to a hospital). This case is different because the tag is essentially duplicating the preset's main tag. Unfortunately, the tagging schema does currently not allow to properly distinguish between the two cases.

It would certainly be possible to hard-code this specific case in iD, although it's not a good solution in the long term.

@tyrasd tyrasd transferred this issue from openstreetmap/iD Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants