Panoramax: Adopt "copy id" feature from mapillary

[gedankenstuecke]

Description

tl;dr: see this comment below for good first issue description

I've been loving the integration of the Panoramax street-level images in iD and started using it to add missing POI from the 360° images I recorded (c.f. this changeset for an example). While doing so, I've tried to add the panoramax key for each new/updated POI using the corresponding image UUID to link back to the source images.

Currently, there's no straightforward workflow in iD to grab those UUID though, the easiest I found was by copying the URL behind the panoramax.xyz in the image footer, to then extract the UUID from the actual URL. While doable, it's quickly becoming a bit annoying, especially when doing lots of POI.

It would help a lot if there was a quick way to copy the UUID to the clipboard, to then set it into the corresponding key/value pair in the editor. Adding it would be straight forward, and could look like the screenshot below:

(Also, I've actually already managed to get that to work on my end, and would be happy to make a PR if folks think it's generally useful/appreciated!)

Screenshots

No response

[tordans]

@gedankenstuecke please test the feature we have for Mapillary from #10046 . I assume this would be a solution for your use case? In this case, we could create an issue to adapt this feature to Panoramax as well.

[gedankenstuecke]

@tordans I had a look at it, and that would be even more comfortable, at least for single images. It seems to not allow associating multiple images with the same object from what I can see?

[gedankenstuecke]

(Oh, and just to flag that adding the copy option would just be ~10 lines of JS and could be done quite quickly as a temporary solution!)

[tordans]

It seems to not allow associating multiple images with the same object from what I can see?

That is correct. There was some discussion whether those imagery fields should default to allow multiple values in openstreetmap/id-tagging-schema#1344 but as far as I remember we agreed to keep them optimized for one value.

[tordans]

(Oh, and just to flag that adding the copy option would just be ~10 lines of JS and could be done quite quickly as a temporary solution!)

I think we should rather strive to only have one feature that does this but have it present for more imagery services.

[tordans]

Good first issue description

• Take what was build in Add panoramax=* universal field id-tagging-schema#1344
• Allow it to work for the panoramax key
• Abstract parts of that feature that might be shared between services in to shared files/functions
• Research if other imagery services have a key (share the wiki page); if so we should add the same feature in follow up PRs

Note that this does not have to wait for openstreetmap/id-tagging-schema#1344; that PR will only improve the visibility of the tag as a preset field but we can already tag it now using the "Tags" section.

[gedankenstuecke]

It seems to not allow associating multiple images with the same object from what I can see?

That is correct. There was some discussion whether those imagery fields should default to allow multiple values in openstreetmap/id-tagging-schema#1344 but as far as I remember we agreed to keep them optimized for one value.

Fair enough, I was thinking of the MapComplete case that was discussed in that PR too, which uses panoramax:0: and is used a bit already (c.f. taginfo).

[tordans]

@gedankenstuecke could your rename this issue into "Panoramax: Adopt "copy id" feature from mapillary" (I cannot edit the title, unfortunately). This will make #10611 (comment) clearer.

[gedankenstuecke]

done, and added a link to your good first issue comment in my initial/parent post!

[Vanshjain2701]

Can you please assign me this?

[tordans]

@Vanshjain2701 this is not how this repository handles issues and PRs. If you feel like you can tackle the ticket, go for it. It was pointed out to me that this is not the easiest "good first issue", so please only submit a PR that you feel confident about. Disclaimer: Please keep in mind that I have no official role in this project so your PR may or may not be accepted by Martin.