Merge pull request #255 from openstax/fix/exercise-bad-attachment

Continue saving exercises even if they have invalid attachments

Author: nathanstitt

Gemfile

@@ -26,8 +26,7 @@ gem 'uglifier', '>= 1.3.0'
 # Use CoffeeScript for .coffee assets and views
 gem 'coffee-rails', '~> 4.1.0'
 
-# See https://github.com/sstephenson/execjs#readme for more supported runtimes
-gem 'therubyracer', platforms: :ruby
+gem 'mini_racer'
 
 # Use jquery as the JavaScript library
 gem 'jquery-rails'

Gemfile.lock

@@ -208,7 +208,7 @@ GEM
       hashie
       transaction_isolation
       transaction_retry
-    libv8 (3.16.14.19)
+    libv8 (6.7.288.46.1)
     lograge (0.10.0)
       actionpack (>= 4)
       activesupport (>= 4)
@@ -227,6 +227,8 @@ GEM
     mini_magick (4.9.3)
     mini_mime (1.0.1)
     mini_portile2 (2.4.0)
+    mini_racer (0.2.4)
+      libv8 (>= 6.3)
     minitest (5.11.3)
     multi_json (1.13.1)
     multi_xml (0.6.0)
@@ -347,7 +349,6 @@ GEM
       redis-store (>= 1.2, < 2)
     redis-store (1.6.0)
       redis (>= 2.2, < 5)
-    ref (2.0.0)
     remotipart (1.4.2)
     representable (3.0.0)
       declarative (~> 0.0.5)
@@ -435,9 +436,6 @@ GEM
     test_xml (0.1.8)
       diffy (~> 3.0)
       nokogiri (>= 1.3.2)
-    therubyracer (0.12.3)
-      libv8 (~> 3.16.14.15)
-      ref
     thin (1.7.2)
       daemons (~> 1.0, >= 1.0.9)
       eventmachine (~> 1.0, >= 1.0.4)
@@ -517,6 +515,7 @@ DEPENDENCIES
   maruku
   mimemagic
   mini_magick
+  mini_racer
   nifty-generators
   oj
   oj_mimic_json
@@ -549,7 +548,6 @@ DEPENDENCIES
   sortability
   squeel
   test_after_commit
-  therubyracer
   thin
   timecop
   turbolinks

lib/has_attachments.rb

@@ -3,7 +3,7 @@ module ActiveRecord
     module Base
       def has_attachments
         class_exec do
-          has_many :attachments, as: :parent, dependent: :destroy, inverse_of: :parent
+          has_many :attachments, as: :parent, dependent: :destroy, inverse_of: :parent, validate: false
         end
       end
     end