Use multiple Ceph secrets in ci_dcn_site role #2518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the ci_dcn_site role creates one secret with all Ceph keys and distributes all of these keys to all DCN sites. This patch makes the role create one secret for each DCN site and only that secret is used at that site. The secret for each DCN site only has the keys that are required. This will make the testing consistent with the documentation. Additional secrets for Ceph configuration are created and `extraMounts` for both the control plane and each dataplane is extended to include the extra secrets so that not all of the Ceph keys are distributed. Jira: https://issues.redhat.com/browse/OSPRH-6603 Signed-off-by: John Fulton <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the ci_dcn_site role creates
one secret with all Ceph keys and distributes
all of these keys to all DCN sites. This patch
makes the role create one secret for each DCN
site and only that secret is used at that site.
The secret for each DCN site only has the keys
that are required. This will make the testing
consistent with the documentation.
Additional secrets for Ceph configuration are
created and
extraMountsfor both the controlplane and each dataplane is extended to include
the extra secrets so that not all of the Ceph
keys are distributed.
Jira: https://issues.redhat.com/browse/OSPRH-6603