Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retries from ci_dcn_site post-ceph deployment #2509

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Remove retries from ci_dcn_site post-ceph deployment #2509

merged 1 commit into from
Nov 4, 2024
+0 −4

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented Nov 3, 2024

The Apply post-ceph DataPlaneDeployment CR task is using The kubernetes.core.k8s module with wait true so there is no need to use retries. In some deployments I have seen this hang and eventually cause the deployment to fail even though oc get openstackdataplanedeployment indicates that it reached Setup complete.

@fultonj
Remove retries from ci_dcn_site post-ceph deployment
66a9b7d 
The `Apply post-ceph DataPlaneDeployment CR` task is using
The `kubernetes.core.k8s` module with wait `true` so there
is no need to use `retries`. In some deployments I have seen
this hang and eventually cause the deployment to fail even
though `oc get openstackdataplanedeployment` indicates that
it reached `Setup complete`.

Signed-off-by: John Fulton <[email protected]>
@github-actions github-actions bot marked this pull request as draft November 3, 2024 15:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@fultonj fultonj marked this pull request as ready for review November 3, 2024 15:30
@fultonj fultonj requested a review from krcmarik November 3, 2024 15:30
@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@pablintino pablintino requested a review from a team November 4, 2024 12:15
@frenzyfriday
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a55182a into openstack-k8s-operators:main Nov 4, 2024
6 checks passed
@fultonj
Copy link
Contributor Author

fultonj commented Nov 4, 2024

/cherrypick 18.0-fr1

@openshift-cherrypick-robot
Copy link

@fultonj: new pull request created: #2514

In response to this:

/cherrypick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krcmarik krcmarik Awaiting requested review from krcmarik

Assignees

@frenzyfriday frenzyfriday

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fultonj @pablintino @frenzyfriday @openshift-cherrypick-robot