[os_net_setup] Add --availability-zone-hint to network creation

[eduolivares]

This PR adds the option to configure external networks for certain AZs. In order to do this, the list availability_zone_hints should be configured as port of cifmw_os_net_setup_config.

[github-actions]

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

[pablintino]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[evallesp]

(non-blocking) suggestion: I see some vars used in the template that are missing of some context and format.
Unsure what's the format of availability_zone_hints but I might have a lot of missing context.

WDYT about adding that to the default file: https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/os_net_setup/defaults/main.yml to see an example?

I'm thinking if it might make sense to rework eventually in the README file to briefly explain each of the possibilities of: cifmw_os_net_setup_config

Apart of this: lgtm

[lewisdenny]

I agree with @evallesp

Please add availability_zone_hints to the role defaults, others are missing but they can be added in a follow up if we get time to refactor this role.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/de855c24e2634b82be544cbafc270baa

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 02s
❌ podified-multinode-edpm-deployment-crc FAILURE in 40m 41s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 17s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test NODE_FAILURE Node request 100-0007647506 failed in 0s
❌ cifmw-pod-pre-commit NODE_FAILURE Node request 100-0007647507 failed in 0s
✔️ build-push-container-cifmw-client SUCCESS in 36m 45s
✔️ cifmw-molecule-os_net_setup SUCCESS in 3m 57s

[eduolivares]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a95eda3d3d44e2b8d13236505d0df66

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 50s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 43s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test NODE_FAILURE Node request 100-0007647714 failed in 0s
❌ cifmw-pod-pre-commit NODE_FAILURE Node request 100-0007647715 failed in 0s
✔️ build-push-container-cifmw-client SUCCESS in 37m 21s
✔️ cifmw-molecule-os_net_setup SUCCESS in 4m 22s

[pablintino]

recheck

[lewisdenny]

/lgtm

Thanks @eduolivares ++