Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing node groups for multicell nodeset #2485

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add missing node groups for multicell nodeset #2485

merged 1 commit into from
Oct 31, 2024

Conversation

bogdando
Copy link
Contributor

@bogdando bogdando commented Oct 23, 2024 •
edited
Loading

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0.0-proposed. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/[email protected]", line 150

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft October 23, 2024 15:17
@bogdando bogdando mentioned this pull request Oct 23, 2024
Open
@bogdando bogdando marked this pull request as ready for review October 23, 2024 15:19
@bogdando
Copy link
Contributor Author

I don't get that error, any help please?

@bogdando
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0.0-proposed. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/[email protected]", line 150

@fserucas
Copy link

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0.0-proposed. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/[email protected]", line 150

@fserucas fserucas mentioned this pull request Oct 25, 2024
Closed
@fserucas
Copy link

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c43d090ba4264e49a2be03a46c87ff68

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 09m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 02s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 46s
❌ cifmw-pod-zuul-files FAILURE in 3m 58s
✔️ build-push-container-cifmw-client SUCCESS in 36m 13s

@bogdando
Copy link
Contributor Author

please merge this

@bogdando
Copy link
Contributor Author

bogdando commented Oct 29, 2024 •
edited
Loading

@cescgina @fserucas PTAL

cescgina added a commit that referenced this pull request Oct 29, 2024
@cescgina
Add missing molecule jobs for roles
084db04 
The adoption_osp_deploy and ci_dcn_sites roles are missing molecule
jobs, which makes the cifmw-pod-zuul-files check fail in another PR[1].
This change adds the output of `make role_molecule` so the molecule job
list is up-to-date.

[1] #2485
@cescgina cescgina mentioned this pull request Oct 29, 2024
Merged
openshift-merge-bot bot pushed a commit that referenced this pull request Oct 29, 2024
@cescgina @openshift-merge-bot
Add missing molecule jobs for roles
ce1929a 
The adoption_osp_deploy and ci_dcn_sites roles are missing molecule
jobs, which makes the cifmw-pod-zuul-files check fail in another PR[1].
This change adds the output of `make role_molecule` so the molecule job
list is up-to-date.

[1] #2485
@cescgina
Copy link
Contributor

recheck

@bogdando
Copy link
Contributor Author

good to go now

@lewisdenny lewisdenny requested a review from a team October 31, 2024 05:05
lewisdenny
lewisdenny approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 20bb03c into openstack-k8s-operators:main Oct 31, 2024
6 checks passed
@viroel
Copy link
Collaborator

viroel commented Oct 31, 2024

/cherrypick 18.0-fr1

@openshift-cherrypick-robot
Copy link

@viroel: new pull request created: #2507

In response to this:

/cherrypick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisdenny lewisdenny lewisdenny approved these changes

@jistr jistr jistr approved these changes

@marios marios marios approved these changes

Assignees

@pablintino pablintino

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bogdando @fserucas @cescgina @pablintino @viroel @openshift-cherrypick-robot @marios @jistr @lewisdenny