Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting order and hooks for test role #2374

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow setting order and hooks for test role #2374

wants to merge 2 commits into from

Conversation

eshulman2
Copy link
Contributor

  • Allow passing hook list directly to hook role
  • Allow setting up stages and hooks for test operator role

Jira: https://issues.redhat.com/browse/OSPRH-10106

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft September 24, 2024 10:03
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e1ceb9f2cf3d47658a3de25c1ed70de8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 16s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 03m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 33s
❌ cifmw-multinode-tempest FAILURE in 1h 05m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 35s
❌ cifmw-pod-pre-commit FAILURE in 7m 04s
✔️ build-push-container-cifmw-client SUCCESS in 30m 49s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 26s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 31s

@eshulman2 eshulman2 force-pushed the test_operator_stages branch 3 times, most recently from f24ddba to c4de17d Compare September 24, 2024 15:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a25d6668f88443eeb5b2e354691eb8dc

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 51s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 18s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 04s
❌ cifmw-multinode-tempest FAILURE in 1h 02m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 49s
❌ cifmw-pod-pre-commit FAILURE in 8m 22s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 50s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 00s
✔️ build-push-container-cifmw-client SUCCESS in 31m 24s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 25s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 16s

@eshulman2 eshulman2 force-pushed the test_operator_stages branch 2 times, most recently from c175381 to 5efbd8f Compare September 24, 2024 17:26
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea84a8ceb689406f85a63f9e9f8d1718

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 40s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 32s
❌ cifmw-multinode-tempest FAILURE in 1h 01m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 29s
❌ cifmw-pod-pre-commit FAILURE in 6m 57s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 18s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 47s
✔️ build-push-container-cifmw-client SUCCESS in 20m 55s
✔️ cifmw-molecule-run_hook SUCCESS in 4m 02s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 54s

@eshulman2 eshulman2 force-pushed the test_operator_stages branch 3 times, most recently from 1c61cd8 to 34ffac9 Compare September 25, 2024 08:19
@eshulman2 eshulman2 marked this pull request as ready for review September 25, 2024 08:24
@eshulman2 eshulman2 force-pushed the test_operator_stages branch 2 times, most recently from c00804c to e6b67aa Compare September 25, 2024 08:28
@eshulman2 eshulman2 requested review from lpiwowar, lewisdenny and cjeanner and removed request for lpiwowar and lewisdenny September 25, 2024 09:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/356c7933ae3e4d3e8f7d675c50cf6f4d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 02s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 08m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 33s
❌ cifmw-multinode-tempest FAILURE in 2h 10m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 35s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 56s
✔️ build-push-container-cifmw-client SUCCESS in 21m 23s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66cee248e9704094af91d7233e2f7d6f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 59s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 07m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 41s
❌ cifmw-multinode-tempest FAILURE in 2h 08m 06s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 43s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 10s
✔️ build-push-container-cifmw-client SUCCESS in 20m 52s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/06637ee9db524abebde2b4541f82f55a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 15s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 06m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 15s
❌ cifmw-multinode-tempest FAILURE in 2h 09m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 05s
✔️ build-push-container-cifmw-client SUCCESS in 37m 14s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a798f82b79d74f5ca0a4774b631ef33f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 28s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 33m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 21s
❌ cifmw-multinode-tempest FAILURE in 2h 11m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 36m 37s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 08s

@lewisdenny lewisdenny removed their request for review October 15, 2024 12:27
@eshulman2 eshulman2 force-pushed the test_operator_stages branch 4 times, most recently from 46961ba to b6645f3 Compare October 15, 2024 16:49
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0f811228ab86406eafd85352bf813d26

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 00s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 07m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 42s
❌ cifmw-multinode-tempest FAILURE in 1h 04m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 50s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 05s
❌ cifmw-pod-zuul-files FAILURE in 3m 54s
❌ build-push-container-cifmw-client FAILURE in 16m 00s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

Job cifmw-molecule-artifacts not defined

The problem appears in the the "github.com/openstack-k8s-operators/ci-framework" project stanza:

project:
github-check:
jobs:
- noop
- cifmw-pod-ansible-test
- cifmw-pod-k8s-snippets-source
- cifmw-pod-pre-commit
- cifmw-pod-zuul-files
- cifmw-content-provider-build-images
...

in "openstack-k8s-operators/ci-framework/zuul.d/projects.yaml@main", line 1

@eshulman2 eshulman2 force-pushed the test_operator_stages branch 3 times, most recently from dc405fa to 5d6fff7 Compare October 27, 2024 15:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/22f6268545be44a8827c3ed6b0040dd3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 46s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 09m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 28s
❌ cifmw-multinode-tempest FAILURE in 2h 09m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 38s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 12s
✔️ build-push-container-cifmw-client SUCCESS in 20m 50s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 2m 04s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 08s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 48s

@eshulman2
Allow setting order and hooks for test role
125e387 
NOTE: this patch will require setting order for all jobs running not only
tempest

- Allow passing hook list directly to hook role
- Allow setting up stages and hooks for test operator role

Jira: https://issues.redhat.com/browse/OSPRH-10106
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/69424dc6f75f4226b53f2a4d2dd82975

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 34s
❌ podified-multinode-edpm-deployment-crc FAILURE in 2h 10m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 33s
❌ cifmw-multinode-tempest FAILURE in 2h 10m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 08s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 54s
✔️ build-push-container-cifmw-client SUCCESS in 20m 55s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 52s

@lpiwowar
Copy link
Contributor

lpiwowar commented Nov 4, 2024

rechecking test-operator job here -> [https://github.com/openstack-k8s-operators/test-operator/pull/215]

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3aecd7e9ba44835a173b9d6b3813d69

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 42s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 32s
❌ cifmw-multinode-tempest FAILURE in 1h 39m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 11s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 35s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 12s
✔️ build-push-container-cifmw-client SUCCESS in 36m 06s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 19s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjeanner cjeanner Awaiting requested review from cjeanner

@pablintino pablintino Awaiting requested review from pablintino

@lpiwowar lpiwowar Awaiting requested review from lpiwowar

Assignees
No one assigned
Labels
do-not-merge/hold va-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eshulman2 @lpiwowar @lewisdenny @pablintino @cjeanner @openshift-merge-robot