allow getting forms from db without appending locale #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow configurability of different strategies of form identity naming
fix codacy util class naming
LZRS
commented
Jul 9, 2021
android-json-form-wizard/src/main/java/com/vijay/jsonwizard/utils/FormUtils.java
Outdated
Show resolved
Hide resolved
ekigamba
suggested changes
Jul 9, 2021
...-wizard/src/main/java/com/vijay/jsonwizard/activities/FormConfigurationJsonFormActivity.java
Outdated
Show resolved
Hide resolved
...-wizard/src/main/java/com/vijay/jsonwizard/activities/FormConfigurationJsonFormActivity.java
Outdated
Show resolved
Hide resolved
Comment on lines
16
to
32
| @Override | ||
| public void writeValue(String stepName, String key, String value, String openMrsEntityParent, String openMrsEntity, String openMrsEntityId) throws JSONException { | ||
| callSuperWriteValue(stepName, key, value, openMrsEntityParent, openMrsEntity, openMrsEntityId); | ||
| } | ||
|
|
||
| @Override | ||
| public void onFormFinish() { | ||
| callSuperFinish(); | ||
| } | ||
|
|
||
| protected void callSuperFinish(){ | ||
| super.onFormFinish(); | ||
| } | ||
|
|
||
| protected void callSuperWriteValue(String stepName, String key, String value, String openMrsEntityParent, String openMrsEntity, String openMrsEntityId) throws JSONException { | ||
| super.writeValue(stepName, key, value, openMrsEntityParent, openMrsEntity, openMrsEntityId); | ||
| } |
There was a problem hiding this comment.
I thought that these four methods were redundant? What do you think?
I think that they each call the super and therefore no need to override and only call super with the exactly same params
There was a problem hiding this comment.
For these I wasn't sure, may be other libraries using native-forms may have had them overridden, because they'd been marked as protected.
...d/src/main/java/com/vijay/jsonwizard/activities/FormConfigurationJsonWizardFormActivity.java
Outdated
Show resolved
Hide resolved
and other formatting improvements
ekigamba
approved these changes
Jul 9, 2021
5 tasks
LZRS
added a commit
to opensrp/opensrp-client-reveal
that referenced
this pull request
Jul 23, 2021
for testing purposes while awaiting opensrp/opensrp-client-native-form#586
LZRS
added a commit
to opensrp/opensrp-client-reveal
that referenced
this pull request
Jul 23, 2021
for testing purposes while awaiting opensrp/opensrp-client-native-form#586
LZRS
added a commit
to opensrp/opensrp-client-reveal
that referenced
this pull request
Jul 23, 2021
while awaiting review for opensrp/opensrp-client-native-form#586
dubdabasoduba
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow configurability of different strategies of form identity naming
The Reveal client app saves forms and form rules to db, with just the filename and no locale appended. This would allow for similar apps to be able to retrieve forms and form rules from db, with no locale appended.
resolving #583
resolving #585