Form config changes #560
Merged
Form config changes #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubdabasoduba
requested changes
Mar 15, 2021
| if (clientForm == null) { | ||
| // Strip anything before the '/' | ||
| if (StringUtils.isNotBlank(fileName) && fileName.contains("/")) { | ||
| localeFormIdentity = localeFormIdentity.split("/")[1]; |
There was a problem hiding this comment.
this might throw and error incase we do not have index 1. It's highly unlikely though
There was a problem hiding this comment.
@dubdabasoduba Added a check for this
ekigamba
suggested changes
Mar 25, 2021
| localeFormIdentity = localeFormIdentity.split("/")[1]; | ||
| } | ||
| //retry with just the filename without the file path prefix | ||
| clientForm = clientFormDao.getActiveClientFormByIdentifier(localeFormIdentity); |
There was a problem hiding this comment.
I think we can put this inside the if block to avoid having 2 ClientFormDao calls if the form is not available and doesn't match the format rule/rule-file-name
ekigamba
previously approved these changes
Mar 25, 2021
ekigamba
approved these changes
Mar 26, 2021
dubdabasoduba
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #559