Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getViewsFromJson invoked twice in optimization branch #526

Open
vincent-karuri opened this issue Dec 1, 2020 · 0 comments
Open

getViewsFromJson invoked twice in optimization branch #526

vincent-karuri opened this issue Dec 1, 2020 · 0 comments
Assignees

Comments

@vincent-karuri
Copy link
Contributor

getViewsFromJson is invoked twice on each widget. This can cause issues in the case that a widget expects some logic to be invoked once during widget instantiation.

For instance, RDT has a case where we launch a camera view when getViewsFromJson is invoked. This invocation is done once in the current master code so no issue there. In the optimize branch however, there's more than one call meaning the camera view will be launched twice. After the first camera view is closed, the user sees a second camera view which is confusing.

This issue will more widely affect all widgets which perform certain non-idempotent actions in getViewsFromJson with the assumption that it is invoked only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants