Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and rename misleading method #130

Open
3 tasks
ekigamba opened this issue Mar 9, 2020 · 0 comments
Open
3 tasks

Remove and rename misleading method #130

ekigamba opened this issue Mar 9, 2020 · 0 comments

Comments

@ekigamba
Copy link
Contributor

ekigamba commented Mar 9, 2020

  • Method org.smartregister.immunization.util.VaccinatorUtils#getVaccineFromVaccineConfigFile method is misleading since it only serves to read special vaccines.
    This method provides a redundant/duplicate cache for vaccines while we have a new cache that was introduced during a refactor.
    The main and only vaccine cache is supposed to be org.smartregister.immunization.ImmunizationLibrary#vaccineCacheMap

TASKS

  • Remove this duplicate cache and fix references from this cache in immunization, child & client applications(bangladesh, zeir, BA)
  • For backwards compatbility, remove the cache but retain the method(s) and their signatures so that they point to the main cache
  • Make sure the special vaccines file is loaded in the main cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant