Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAVE button placement consistent throughout the app #68

Open
cafootitt opened this issue Mar 8, 2021 · 3 comments
Open

Make SAVE button placement consistent throughout the app #68

cafootitt opened this issue Mar 8, 2021 · 3 comments
Labels
Android blocked enhancement New feature or request

Comments

@cafootitt
Copy link

cafootitt commented Mar 8, 2021

  • Service Point Check - SAVE at top only
  • Flag problem - SAVE at top and at bottom (this is because this is the only paginated form, so the SAVE button on the last page is next to the PREVIOUS button)
  • Fix problem - SAVE at top only
  • Record GPS - SAVE at top only

@rowo Should we just remove the SAVE button at the bottom of the paginated Flag Problem form? This might need to be changed in the native form library, so all other apps would be affected as well with this change.

We had started discussing this for wcaro as well, but the issue got de-prioritized for that project.

Screenshot_20210308-144456_eusm

@cafootitt cafootitt added enhancement New feature or request Android labels Mar 8, 2021
@rowo
Copy link

rowo commented Mar 9, 2021

@cafootitt Let's remove the save button from the top and use the Save button at the bottom. If we are going to choose one place, we might as well follow the ODK Collect lead and go at the end of the form.

If this is going to be a native form impacting change, can we style the button in a rounded button as well? See below.

One two button views it would go like this:
savebutton

On single button views it would go like this:
savebutton2

@cafootitt
Copy link
Author

Thanks @rowo I think as next step, we'll discuss on the next EUSM standup and see what implications this change will have on native form library (and LOE) and other projects

@cafootitt
Copy link
Author

Standup notes:

  • Change would happen in native form library
  • Make it a design configuration, so other projects could opt in to the change
  • LOE: 1 day plus 1 day buffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants