Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation bugs for CHW and HF apps #300

Open
2 tasks
ellykits opened this issue Oct 9, 2020 · 2 comments
Open
2 tasks

Translation bugs for CHW and HF apps #300

ellykits opened this issue Oct 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@ellykits
Copy link
Contributor

ellykits commented Oct 9, 2020

Introduction

The following translation bugs were reported for HF application but after further investigation I noticed similar issues in the CHW app. This is due to the fact that we share same code base for both CHW and HF app. Meaning fixing some of the issues will resolve the bugs for the 2 apps (apart from the overridden implementations).

Some of the translation issues above have been resolved with this PR #299. However there are a couple of translation issues that will need update to the code logic so that the right translations are picked at runtime.

Possible causes

  • Spinner values save the option labels instead of the key
  • Some string values saved in the SQLITE database and their content used as they are without being translated (Affecting registers and profiles)
  • Some strings are part of returned query results like in the case of All Clients register

Possible fixes

  1. For spinner values, use the keys instead of the actual spinner option labels then use the key to get the right translated string from the JSON form. Alternatively have a logic to map the saved value to a string resource that can be translated (this would be recommended in situations where we have data in production that saved the option labels instead)
  2. Provide a custom logic to map strings saved on database to translatable string resources for the strings that are saved on the database
  3. Provide custom logic to replace translatable strings of the returned query results e.g for All Cients returned results replace every occurrence of the gender string with the right translated value from the string xml file
@ellykits ellykits added the bug Something isn't working label Oct 9, 2020
@msschroeder
Copy link

Translations remaining:
CHW App:

  • Community Responder:

  • Add a new community responder/Edit a community responder form:
    Screenshot_20201012-100430

  • Malaria

  • The sex on the register/profile page
    Screenshot_20201012-100955
    Screenshot_20201012-101008

  • Family Planning:

  • Type of family planning on the register page
    Screenshot_20201012-101017

  • The sex on the family planning profile
    Screenshot_20201012-101025

  • Referral Register

  • Type of referral is not in Swahili
    Screenshot_20201012-101040

  • Referral is not completely translated
    Uploading Screenshot_20201012-101057.png…

@msschroeder
Copy link

Translations:
HF:

  • All Clients Register

  • The heading ("All Clients"), gender, and type of client (i.e. Malaria, ANC, Family Planning) on the All Clients Register are in English
    Screenshot_20201012-103126

  • All Families Register

  • Family profile > the Family name is in English (e.g. Obrien Family which should be Kaya ya Obrien)
    Screenshot_20201012-102521

  • Child Register

  • The child's gender is in English on register:
    Screenshot_20201012-102615

  • Family Planning

  • Type of family planning in English on FP Register page
    Screenshot_20201012-102632

  • Gender is in English on FP profile page - Male profile page (head of family registered for FP)
    Screenshot_20201012-102637

  • Malaria Register

  • Gender on Malaria Register and profile page in English
    Screenshot_20201012-102647
    Screenshot_20201012-102650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants