Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perfomance Enhancements #3486

Closed
5 of 16 tasks
f-odhiambo opened this issue Sep 11, 2024 · 4 comments
Closed
5 of 16 tasks

Perfomance Enhancements #3486

f-odhiambo opened this issue Sep 11, 2024 · 4 comments
Assignees
@pld @qiarie
Labels
Performance (App or Server) SID Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Milestone
Sprint 24 (Novemb...

Comments

@f-odhiambo
Copy link
Contributor

f-odhiambo commented Sep 11, 2024 •
edited by qiarie
Loading

What to test

FHIRCore

  • 1. App Launch - Time is taken from Press App Icon move auth page
  • 2. Login - First-time login and Subsequent Login when resuming from the background
  • 3. UI (Registers and Profiles): Splitting Queries that may be large into smaller ones to allow for other transitions to get processing time
  • 4. Initial sync. Sample metrics from WDF found on this ticket

Content review

  • 1. Rules engine - review configs to optimize and remove unused rules and extensions
  • 2. Review how inter-form and inter-visit logic is currently being implemented for possible areas of refactoring to optimize data queries (Potentially use Forward include, Reverse include, etc while getting Related Resources)
  • 3. Triage Questionnaire population (Related Expressions (FHIRPath) being executed or prepopulated) - improve load and save times
  • 4. Triage FHIRPath expressions evaluation and extensions - benchmarking

Android FHIR SDK

  • 1. Triage query performance for searches and data queries
  • 2. Triage Extraction of nested rules on StructureMaps - benchmarking

Where to start

  • 1. Add all release flavors based on the latest artifacts FHIR Core and SDK to a branch
  • 2. Publish a release artifact - This can be done locally or using GitHub actions
  • 3. Cut release APKs flavor based on the above branch
  • 4. Benchmark the APKs
  • 5. Maintain the branch for subsequent updates
  • 6. Repeat 3,4,5
@f-odhiambo f-odhiambo added Draft Performance (App or Server) Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions SID labels Sep 11, 2024
@f-odhiambo
Copy link
Contributor Author

As shared from email

image

@f-odhiambo
Copy link
Contributor Author

There is a branch that was built by @LZRS here https://github.com/opensrp/fhircore/tree/experiment-perf-branch that @qiarie you can build upon

@qiarie
Copy link
Contributor

qiarie commented Sep 11, 2024

@f-odhiambo This branch has the latest updates and dependencies performance-improvements

@f-odhiambo f-odhiambo removed the Draft label Sep 12, 2024
@ndegwamartin ndegwamartin added this to the FHIR Core Performance milestone Nov 5, 2024
@Rkareko Rkareko mentioned this issue Nov 11, 2024
Closed
@ndegwamartin ndegwamartin mentioned this issue Nov 18, 2024
Merged
11 tasks
@pld pld self-assigned this Nov 25, 2024
pld added a commit that referenced this issue Nov 26, 2024
@pld
add performance testing doc, closes #2064 #2065 #3486
654cf26
pld added a commit that referenced this issue Nov 27, 2024
@pld
add performance testing doc, closes #2064 #2065 #3486 (#3636)
b13cff1 
* add performance testing doc, closes #2064 #2065 #3486

* fix style
@pld
Copy link
Member

pld commented Nov 27, 2024

#3636

@pld pld closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pld pld

@qiarie qiarie

Labels
Performance (App or Server) SID Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Projects
None yet
Milestone
Sprint 24 (November 15th - December 2nd)
Development

No branches or pull requests
4 participants
@pld @qiarie @f-odhiambo @ndegwamartin