Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the CShutterBase interface to offer setPower()/getPower() #10

Open
dscho opened this issue Apr 20, 2015 · 2 comments
Open

Extend the CShutterBase interface to offer setPower()/getPower() #10

dscho opened this issue Apr 20, 2015 · 2 comments
Assignees

Comments

@dscho
Copy link
Contributor

dscho commented Apr 20, 2015

It was not very clever by us to implement our own Laser interface. Not only did we re-invent our own, poor plugin architecture, we also made a poor design choice: the setPower()/getPower() accessors should be an integral part of the CShutterBase interface because the device adapters know better than anybody else how (or if) the laser power can be set.

So let's finally correct that mistake by working with the Micro-Manager team to extend the Micro-Manager API, for everybody's benefit.

This is most likely quite a bit of work because essentially all 93 of the files reported by git grep -w CShutterBase DeviceAdapters/ will need to be adjusted.

@dscho
Copy link
Contributor Author

dscho commented Apr 20, 2015

Note: I assigned @hkmoon but of course I will work closely with him to get this change into Micro-Manager proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants