Fix lints.

Author: bergmannf

cmd/cluster/context.go

@@ -73,7 +73,6 @@ func (o ContextOptions) Validate() error {
 	default:
 		return fmt.Errorf("unknown Output Format: %s", o.Output)
 	}
-	return nil
 }
 
 // ContextCache holds the runtime state and cluster information needed during execution.
@@ -284,7 +283,10 @@ func GenerateContextData(clusterId string) (string, []error) {
 
 	builder := &strings.Builder{}
 	presenter := NewClusterContextPresenter(builder)
-	presenter.Render(contextData, queryOpts)
+	err = presenter.Render(contextData, queryOpts)
+	if err != nil {
+			errs = append(errs, err)
+	}
 	return builder.String(), errs
 }
 

cmd/cluster/context_presenter.go

@@ -159,7 +159,7 @@ func (p *ClusterContextPresenter) RenderJSON(data *contextData) error {
 
 // printOtherLinks prints external resource links
 func (p *ClusterContextPresenter) printOtherLinks(data *contextData, opts ContextOptions) {
-	var name string = "External resources"
+	name := "External resources"
 	fmt.Fprintln(p.writer, delimiter+name)
 
 	var ohssQueryURL = fmt.Sprintf("%[1]s/issues/?jql=project%%20%%3D%%22OpenShift%%20Hosted%%20SRE%%20Support%%22and%%20(%%22Cluster%%20ID%%22%%20~%%20%%20%%22%[2]s%%22OR%%22Cluster%%20ID%%22~%%22%[3]s%%22OR%%22description%%22~%%22%[2]s%%22OR%%22description%%22~%%22%[3]s%%22)",
@@ -235,7 +235,7 @@ func buildHCPSplunkURL(baseURL string, environment string, cluster *cmv1.Cluster
 
 // printHistoricalPDAlertSummary prints a summary of historical PagerDuty alerts
 func (p *ClusterContextPresenter) printHistoricalPDAlertSummary(incidentCounters map[string][]*pagerduty.IncidentOccurrenceTracker, serviceIDs []string, sinceDays int) {
-	var name string = "PagerDuty Historical Alerts"
+	name := "PagerDuty Historical Alerts"
 	fmt.Fprintln(p.writer, delimiter+name)
 
 	for _, serviceID := range serviceIDs {
@@ -266,7 +266,7 @@ func (p *ClusterContextPresenter) printHistoricalPDAlertSummary(incidentCounters
 
 // printJIRASupportExceptions prints JIRA support exception tickets
 func (p *ClusterContextPresenter) printJIRASupportExceptions(issues []jira.Issue) {
-	var name string = "Support Exceptions"
+	name := "Support Exceptions"
 	fmt.Fprintln(p.writer, delimiter+name)
 
 	for _, i := range issues {
@@ -281,7 +281,7 @@ func (p *ClusterContextPresenter) printJIRASupportExceptions(issues []jira.Issue
 
 // printCloudTrailLogs prints potentially interesting CloudTrail events
 func (p *ClusterContextPresenter) printCloudTrailLogs(events []*types.Event) {
-	var name string = "Potentially interesting CloudTrail events"
+	name := "Potentially interesting CloudTrail events"
 	fmt.Fprintln(p.writer, delimiter+name)
 
 	if events == nil {
@@ -327,7 +327,7 @@ func (p *ClusterContextPresenter) printNetworkInfo(data *contextData) {
 
 // printDynatraceResources prints Dynatrace-related URLs and information
 func (p *ClusterContextPresenter) printDynatraceResources(data *contextData) {
-	var name string = "Dynatrace Details"
+	name := "Dynatrace Details"
 	fmt.Fprintln(p.writer, delimiter+name)
 
 	links := map[string]string{
@@ -360,7 +360,7 @@ func (p *ClusterContextPresenter) printDynatraceResources(data *contextData) {
 
 // printUserBannedStatus prints user ban status and details
 func (p *ClusterContextPresenter) printUserBannedStatus(data *contextData) {
-	var name string = "User Ban Details"
+	name := "User Ban Details"
 	fmt.Fprintln(p.writer, "\n"+delimiter+name)
 	if data.UserBanned {
 		fmt.Fprintln(p.writer, "User is banned")

cmd/cluster/context_test.go

@@ -395,7 +395,8 @@ func TestPrintShortOutput(t *testing.T) {
 
 	buffer := strings.Builder{}
 	p := NewClusterContextPresenter(&buffer)
-	p.RenderShort(data, opts)
+	err := p.RenderShort(data, opts)
+	assert.NoError(t, err)
 	output := buffer.String()
 
 	assert.Contains(t, output, "Version")
@@ -418,11 +419,12 @@ func TestPrintJsonOutput(t *testing.T) {
 
 	buffer := strings.Builder{}
 	p := NewClusterContextPresenter(&buffer)
-	p.RenderJSON(data)
+	err := p.RenderJSON(data)
+	assert.NoError(t, err)
 	output := buffer.String()
 
 	var result map[string]interface{}
-	err := json.Unmarshal([]byte(output), &result)
+	err = json.Unmarshal([]byte(output), &result)
 	assert.NoError(t, err)
 	assert.Contains(t, output, `"JSON Test Cluster"`)
 	assert.Contains(t, output, `"4.9"`)
@@ -518,7 +520,8 @@ func TestPrintLongOutput(t *testing.T) {
 
 	buffer := strings.Builder{}
 	p := NewClusterContextPresenter(&buffer)
-	p.RenderLong(mockData, *o)
+	err := p.RenderLong(mockData, *o)
+	assert.NoError(t, err)
 	output := buffer.String()
 
 	assert.Contains(t, output, "ClusterABC")

cmd/mcp/cmd.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"net/http"
+	"time"
 
 	"github.com/google/jsonschema-go/jsonschema"
 	"github.com/modelcontextprotocol/go-sdk/mcp"
@@ -81,7 +82,12 @@ func runMCP(cmd *cobra.Command, argv []string) error {
 		handler := mcp.NewStreamableHTTPHandler(func(req *http.Request) *mcp.Server {
 			return server
 		}, nil)
-		if err := http.ListenAndServe(fmt.Sprintf("http://localhost:%d", httpPort), handler); err != nil {
+		server := &http.Server{
+				Addr:              fmt.Sprintf("http://localhost:%d", httpPort),
+				ReadHeaderTimeout: 3 * time.Second,
+		}
+		http.Handle("/", handler)
+		if err := server.ListenAndServe(); err != nil {
 			return err
 		}
 	}