Add MCP method to list service logs for a cluster.

Author: bergmannf

cmd/cluster/context.go

@@ -7,8 +7,6 @@ import (
 	"net"
 	"os"
 	"os/exec"
-	"sort"
-	"strconv"
 	"strings"
 	"sync"
 	"time"
@@ -25,7 +23,6 @@ import (
 	"github.com/openshift/osdctl/cmd/dynatrace"
 	"github.com/openshift/osdctl/pkg/osdCloud"
 	"github.com/openshift/osdctl/pkg/osdctlConfig"
-	"github.com/openshift/osdctl/pkg/printer"
 	"github.com/openshift/osdctl/pkg/provider/pagerduty"
 	"github.com/openshift/osdctl/pkg/utils"
 	"github.com/spf13/cobra"
@@ -66,6 +63,16 @@ func (o ContextOptions) Validate() error {
 	if o.Days < 1 {
 		return fmt.Errorf("cannot have a days value lower than 1")
 	}
+	switch o.Output {
+	case shortOutputConfigValue:
+		return nil
+	case longOutputConfigValue:
+		return nil
+	case jsonOutputConfigValue:
+		return nil
+	default:
+		return fmt.Errorf("unknown Output Format: %s", o.Output)
+	}
 	return nil
 }
 
@@ -627,75 +634,6 @@ func GetCloudTrailLogsForCluster(awsProfile string, clusterID string, maxPages i
 	return filteredEvents, nil
 }
 
-func printHistoricalPDAlertSummary(incidentCounters map[string][]*pagerduty.IncidentOccurrenceTracker, serviceIDs []string, sinceDays int, w io.Writer) {
-	var name string = "PagerDuty Historical Alerts"
-	fmt.Fprintln(w, delimiter+name)
-
-	for _, serviceID := range serviceIDs {
-
-		if len(incidentCounters[serviceID]) == 0 {
-			fmt.Fprintln(w, "Service: https://redhat.pagerduty.com/service-directory/"+serviceID+": None")
-			continue
-		}
-
-		fmt.Fprintln(w, "Service: https://redhat.pagerduty.com/service-directory/"+serviceID+":")
-		table := printer.NewTablePrinter(w, 20, 1, 3, ' ')
-		table.AddRow([]string{"Type", "Count", "Last Occurrence"})
-		totalIncidents := 0
-		for _, incident := range incidentCounters[serviceID] {
-			table.AddRow([]string{incident.IncidentName, strconv.Itoa(incident.Count), incident.LastOccurrence})
-			totalIncidents += incident.Count
-		}
-
-		// Add empty row for readability
-		table.AddRow([]string{})
-		if err := table.Flush(); err != nil {
-			fmt.Fprintf(w, "Error printing %s: %v\n", name, err)
-		}
-
-		fmt.Fprintln(w, "\tTotal number of incidents [", totalIncidents, "] in [", sinceDays, "] days")
-	}
-}
-
-func printJIRASupportExceptions(issues []jira.Issue, w io.Writer) {
-	var name string = "Support Exceptions"
-	fmt.Fprintln(w, delimiter+name)
-
-	for _, i := range issues {
-		fmt.Fprintf(w, "[%s](%s/%s): %+v [Status: %s]\n", i.Key, i.Fields.Type.Name, i.Fields.Priority.Name, i.Fields.Summary, i.Fields.Status.Name)
-		fmt.Fprintf(w, "- Link: %s/browse/%s\n\n", JiraBaseURL, i.Key)
-	}
-
-	if len(issues) == 0 {
-		fmt.Fprintln(w, "None")
-	}
-}
-
-func printCloudTrailLogs(events []*types.Event, w io.Writer) {
-	var name string = "Potentially interesting CloudTrail events"
-	fmt.Fprintln(w, delimiter+name)
-
-	if events == nil {
-		fmt.Fprintln(w, "None")
-		return
-	}
-
-	table := printer.NewTablePrinter(w, 20, 1, 3, ' ')
-	table.AddRow([]string{"EventId", "EventName", "Username", "EventTime"})
-	for _, event := range events {
-		if event.Username == nil {
-			table.AddRow([]string{*event.EventId, *event.EventName, "", event.EventTime.String()})
-		} else {
-			table.AddRow([]string{*event.EventId, *event.EventName, *event.Username, event.EventTime.String()})
-		}
-	}
-	// Add empty row for readability
-	table.AddRow([]string{})
-	if err := table.Flush(); err != nil {
-		fmt.Fprintf(w, "Error printing %s: %v\n", name, err)
-	}
-}
-
 // These are a list of skippable aws event types, as they won't indicate any modification on the customer's side.
 func skippableEvent(eventName string) bool {
 	skippableList := []string{
@@ -717,87 +655,9 @@ func skippableEvent(eventName string) bool {
 	return false
 }
 
-func printNetworkInfo(data *contextData, w io.Writer) {
-	var name = "Network Info"
-	fmt.Fprintln(w, delimiter+name)
-
-	table := printer.NewTablePrinter(w, 20, 1, 3, ' ')
-	table.AddRow([]string{"Network Type", data.NetworkType})
-	table.AddRow([]string{"MachineCIDR", data.NetworkMachineCIDR})
-	table.AddRow([]string{"ServiceCIDR", data.NetworkServiceCIDR})
-	table.AddRow([]string{"Max Services", strconv.Itoa(data.NetworkMaxServices)})
-	table.AddRow([]string{"PodCIDR", data.NetworkPodCIDR})
-	table.AddRow([]string{"Host Prefix", strconv.Itoa(data.NetworkHostPrefix)})
-	table.AddRow([]string{"Max Nodes (based on PodCIDR)", strconv.Itoa(data.NetworkMaxNodesFromPodCIDR)})
-	table.AddRow([]string{"Max pods per node", strconv.Itoa(data.NetworkMaxPodsPerNode)})
-
-	if err := table.Flush(); err != nil {
-		fmt.Fprintf(w, "Error printing %s: %v\n", name, err)
-	}
-}
-
-func printDynatraceResources(data *contextData, w io.Writer) {
-	var name string = "Dynatrace Details"
-	fmt.Fprintln(w, delimiter+name)
-
-	links := map[string]string{
-		"Dynatrace Tenant URL": data.DyntraceEnvURL,
-		"Logs App URL":         data.DyntraceLogsURL,
-	}
-
-	// Sort, so it's always a predictable order
-	var keys []string
-	for k := range links {
-		keys = append(keys, k)
-	}
-	sort.Strings(keys)
-
-	table := printer.NewTablePrinter(w, 20, 1, 3, ' ')
-	for _, link := range keys {
-		url := strings.TrimSpace(links[link])
-		if url == dynatrace.ErrUnsupportedCluster.Error() {
-			fmt.Fprintln(w, dynatrace.ErrUnsupportedCluster.Error())
-			break
-		} else if url != "" {
-			table.AddRow([]string{link, url})
-		}
-	}
-
-	if err := table.Flush(); err != nil {
-		fmt.Fprintf(w, "Error printing %s: %v\n", name, err)
-	}
-}
-
-func printUserBannedStatus(data *contextData, w io.Writer) {
-	var name string = "User Ban Details"
-	fmt.Fprintln(w, "\n"+delimiter+name)
-	if data.UserBanned {
-		fmt.Fprintln(w, "User is banned")
-		fmt.Fprintf(w, "Ban code = %v\n", data.BanCode)
-		fmt.Fprintf(w, "Ban description = %v\n", data.BanDescription)
-		if data.BanCode == BanCodeExportControlCompliance {
-			fmt.Fprintln(w, "User banned due to export control compliance.\nPlease follow the steps detailed here: https://github.com/openshift/ops-sop/blob/master/v4/alerts/UpgradeConfigSyncFailureOver4HrSRE.md#user-banneddisabled-due-to-export-control-compliance .")
-		}
-	} else {
-		fmt.Fprintln(w, "User is not banned")
-	}
-}
-
 func (data *contextData) printClusterHeader(w io.Writer) {
 	clusterHeader := fmt.Sprintf("%s -- %s", data.ClusterName, data.ClusterID)
 	fmt.Fprintln(w, strings.Repeat("=", len(clusterHeader)))
 	fmt.Fprintln(w, clusterHeader)
 	fmt.Fprintln(w, strings.Repeat("=", len(clusterHeader)))
 }
-
-func printSDNtoOVNMigrationStatus(data *contextData, w io.Writer) {
-	name := "SDN to OVN Migration Status"
-	fmt.Fprintln(w, "\n"+delimiter+name)
-
-	if data.SdnToOvnMigration != nil && data.MigrationStateValue == cmv1.ClusterMigrationStateValueInProgress {
-		fmt.Fprintln(w, "SDN to OVN migration is in progress")
-		return
-	}
-
-	fmt.Fprintln(w, "No active SDN to OVN migrations")
-}