-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-64584 Modify DPU Operator Docs to reflect 4.20 code #101591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Wed Nov 12 14:23:44 - Prow CI generated the docs preview: https://101591--ocpdocs-pr.netlify.app/ |
|
@bn222 @wizhaoredhat I made updates can you PTAL again, tried to consolidate all the feedback and get a better picture adding a new section on status |
bn222
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment otherwise lgtm
c6215ea to
00c8303
Compare
|
/lgtm |
|
/lgtm |
|
/lgtm |
d177e6c to
1ecb870
Compare
720c57e to
bb7c765
Compare
slovern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggestions
formatting fix formatting fix 2 fixing vale errors 5 fixing vale errors 6 fixing vale errors 7
1130ffc to
f6e32b5
Compare
| @@ -0,0 +1,17 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.
|
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
@slovern: new pull request created: #102393 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slovern: new pull request created: #102394 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.20, 4.21 and Main
Issue: https://issues.redhat.com/browse/OCPBUGS-64584
Link to docs preview: https://101591--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/dpu-operator/dpu-operator.html
QE review:
Additional information: