Skip to content

Conversation

@kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Nov 3, 2025

Version(s): 4.20, 4.21 and Main

Issue: https://issues.redhat.com/browse/OCPBUGS-64584

Link to docs preview: https://101591--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/dpu-operator/dpu-operator.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 3, 2025

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2025
@kquinn1204
Copy link
Contributor Author

@bn222 @wizhaoredhat I made updates can you PTAL again, tried to consolidate all the feedback and get a better picture adding a new section on status

Copy link

@bn222 bn222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment otherwise lgtm

@zhiqiangf
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@wizhaoredhat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025
@zhiqiangf
Copy link

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
Copy link
Contributor

@slovern slovern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions

formatting fix

formatting fix 2

fixing vale errors 5

fixing vale errors 6

fixing vale errors 7
@@ -0,0 +1,17 @@
// Module included in the following assemblies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wizhaoredhat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@slovern slovern added this to the Continuous Release milestone Nov 12, 2025
@slovern slovern merged commit 8fcf0c9 into openshift:main Nov 12, 2025
2 checks passed
@slovern
Copy link
Contributor

slovern commented Nov 12, 2025

/cherrypick enterprise-4.21

@slovern
Copy link
Contributor

slovern commented Nov 12, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@slovern: new pull request created: #102393

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@slovern: new pull request created: #102394

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants